On Tue, 15 May 2018 at 20:40:15 +0100, Simon McVittie wrote:
> osc's Build-Depends are insufficient to run `debian/rules clean`
> (Policy §7.7), because they don't include two packages that provide
> debhelper sequences.

Those packages are actually insufficient too, because `setup.py clean`
indirectly imports python-urlgrabber. Better patch attached.

    smcv
>From efec71c9c7e28f6e6beef25426989f226f3023a2 Mon Sep 17 00:00:00 2001
From: Simon McVittie <simon.mcvit...@collabora.co.uk>
Date: Tue, 15 May 2018 20:34:34 +0100
Subject: [PATCH] Merge Build-Depends-Indep into Build-Depends
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The python2 and bash-completion debhelper sequences are needed for
the clean target when building a source package, but that target is
only guaranteed to have the Build-Depends available (Policy §7.7); and
python-urlgrabber turns out to also be needed during clean, because
it's indirectly imported by setup.py.

Closes: #898775
---
 debian/changelog | 12 ++++++++++++
 debian/control   | 12 ++++++------
 2 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 63d283c..e14f894 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,15 @@
+osc (0.162.1-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Merge Build-Depends-Indep into Build-Depends. The python2 and
+    bash-completion debhelper sequences are needed for the clean target
+    when building a source package, but that target is only guaranteed to
+    have the Build-Depends available; and python-urlgrabber turns out to
+    also be needed during clean, because it's indirectly imported
+    by setup.py. (Closes: #898775)
+
+ -- Simon McVittie <s...@collabora.com>  Tue, 15 May 2018 20:04:29 +0100
+
 osc (0.162.1-1) unstable; urgency=medium
 
   * New upstream release.
diff --git a/debian/control b/debian/control
index 1d5b1c8..4414a47 100644
--- a/debian/control
+++ b/debian/control
@@ -3,12 +3,12 @@ Maintainer: RPM packaging team <pkg-rpm-de...@lists.alioth.debian.org>
 Uploaders: Michal Čihař <ni...@debian.org>
 Section: devel
 Priority: optional
-Build-Depends: debhelper (>= 9),
-               dh-exec
-Build-Depends-Indep: python,
-                     python-urlgrabber,
-                     dh-python,
-                     bash-completion
+Build-Depends: bash-completion,
+               debhelper (>= 9),
+               dh-exec,
+               dh-python,
+               python,
+               python-urlgrabber
 Standards-Version: 4.1.3
 Vcs-Browser: https://anonscm.debian.org/git/pkg-rpm/osc.git
 Vcs-Git: https://anonscm.debian.org/git/pkg-rpm/osc.git
-- 
2.17.0

Reply via email to