Source: kgb-bot
Source-Version: 1.50-1
Severity: normal

Hi!

Due to #895004, the semantics of Dpkg::Version in bool context got
unbroken back to their original behavior. This was at the time and
it is now again an API break, but any other solution was deemed worse.
To avoid silent breakage the module now emits a perl warning so that
users can check and fix the broken code or quiesce the warning.

After a cursory review, I think there's such problematic usage in
script/kgb-ci-report, in the following line:

  79:   next unless $wanted_packages{ $pkg_info->{package} };

If the new behavior is fine (bool evaluation will be an alias to
is_valid()), then please add the following until dpkg 1.20.x:

  no if $Dpkg::Version::VERSION ge '1.02',
     warnings => qw(Dpkg::Version::semantic_change::overload::bool);

otherwise, please change that to match the previous behavior of
as_string() if is_valid().

Thanks,
Guillem

Reply via email to