On 2019-02-15 10:33 p.m., Gabriel Filion wrote: > On 2019-02-15 7:53 a.m., Axel Beckert wrote: >> sorry for the late report, but smokeping failed to configure (probably >> after the recent upgrade) for a few days for me now: >> >> # dpkg --configure -a >> Setting up smokeping (2.7.3-1) ... >> apache2_invoke: Enable module cgi >> [ ok ] Restarting Apache httpd web server: apache2 >> apache2_invoke smokeping: already enabled >> [ ok ] Reloading Apache httpd web server: apache2. >> [....] Shutting down latency logger daemon: smokepingstart-stop-daemon: >> matching only on non-root pidfile /var/run/smokeping/smokeping.pid is >> insecure > >> This seems to happen since dpkg 1.19.3. According changelog entry: > > Thanks for bringing this to our attention! > > dpkg 1.19.3 was migrated to testing only a couple days before smokeping > 2.7.3-1, so maybe when Antoine and I were working on this release our > tests were running on a previous dpkg version: I've tested out an > install of smokeping on a fresh install with the init script but I > didn't notice any error about the pid. > > I'll run more tests to try and reproduce this.
I was able to reproduce this bug by switching an amd64 debian sid VM to boot using sysvinit, and then to run "dpkg-reconfigure smokeping" when using the systemd unit, the pid file is owned by root:root and we're not encountering this issue. I've found an example for a fix in #920466 that worked for me: adding "--exec $DAEMON" to the s-s-d command that stops the daemon makes it possible to stop the daemon without error. I'll push this fix to salsa and ask for Antoine to review and upload.
signature.asc
Description: OpenPGP digital signature
