Package: release.debian.org Severity: normal Hello release team.
I would like to upload a new version of nheko to fix #926671. It is an "important" bug (though in reality, it could be argued that it is "serious", as Matrix will be bumping the default room version soon, which will cause the bug to manifest much more commonly, making the program less usable). The fix is to apply a small patch from upstream. Attached is a debdiff. In addition to the above issue, I would like to also include fixes for the following bugs, which are not included in the attached debdiff, but are fairly trivial: - #926659 - incorrectly named file (debian/README.sources instead of debian/README.source) -- has an obvious fix - #926680 - a working directory is not properly cleaned up if the build fails -- I would just add the working directory to the list of files that are "rm -rf"-ed in override_dh_auto_clean. -- System Information: Debian Release: 9.8 APT prefers stable APT policy: (990, 'stable'), (500, 'stable-updates'), (300, 'testing'), (200, 'unstable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.19.0-1-amd64 (SMP w/4 CPU cores) Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en_GB (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system)
diff -Nru nheko-0.6.3/debian/changelog nheko-0.6.3/debian/changelog --- nheko-0.6.3/debian/changelog 2019-02-08 15:35:59.000000000 -0500 +++ nheko-0.6.3/debian/changelog 2019-04-08 18:00:01.000000000 -0400 @@ -1,3 +1,9 @@ +nheko (0.6.3-2) unstable; urgency=medium + + * Support v3 rooms (Closes: #926671) + + -- Hubert Chathi <uho...@debian.org> Mon, 08 Apr 2019 18:00:01 -0400 + nheko (0.6.3-1) unstable; urgency=medium * New upstream release. diff -Nru nheko-0.6.3/debian/patches/series nheko-0.6.3/debian/patches/series --- nheko-0.6.3/debian/patches/series 2019-02-08 15:35:01.000000000 -0500 +++ nheko-0.6.3/debian/patches/series 2019-04-08 17:57:30.000000000 -0400 @@ -1,2 +1,3 @@ no_rpath nlohmann-json +v3_support diff -Nru nheko-0.6.3/debian/patches/v3_support nheko-0.6.3/debian/patches/v3_support --- nheko-0.6.3/debian/patches/v3_support 1969-12-31 19:00:00.000000000 -0500 +++ nheko-0.6.3/debian/patches/v3_support 2019-04-08 17:56:34.000000000 -0400 @@ -0,0 +1,27 @@ +Author: redsky17 <joedono...@gmail.com> +Bug: https://github.com/Nheko-Reborn/mtxclient/issues/3 +Bug-Debian: https://bugs.debian.org/926671 +Description: Fix Room v3 Issue + This at least partially addresses #3. I have a feeling that + additional updates will be needed at some point, but this + fixes the issue where mtxclient would throw an exception for + unrecognized event id formats, which caused nheko to crash. +Origin: backport, https://github.com/Nheko-Reborn/mtxclient/commit/67d39691666bcdf3cc660db19ccc0d9941df13fd +Last-Update: 2019-04-08 + +diff --git a/mtxclient/include/mtx/identifiers.hpp b/mtxclient/include/mtx/identifiers.hpp +index 87acc43..7885885 100644 +--- a/mtxclient/include/mtx/identifiers.hpp ++++ b/mtxclient/include/mtx/identifiers.hpp +@@ -90,7 +90,10 @@ parse(const std::string &id) + identifier.hostname_ = id.substr(parts + 1); + identifier.id_ = id; + } else { +- throw std::invalid_argument(id + ": invalid format\n"); ++ // V3 event ids don't use ':' at all, don't parse them the same way. ++ identifier.localpart_ = id; ++ identifier.hostname_ = id; ++ identifier.id_ = id; + } + + return identifier;
