Package: ciftilib
Version: 1.5.3-2
Severity: wishlist
Tags: patch
User: team+bo...@tracker.debian.org
Usertags: boost1.71

Dear Maintainer,

your package fails to build with boost1.71. You can find a build log
attached. If you want to attempt the build yourself, an updated version
of boost-defaults which brings in boost1.71 dependencies can be found
adding this line to your sources.list file:

  deb https://people.debian.org/~gio/reprepro gio main

This bug has severity whishlist for the moment, but it will raised to RC
as soon as version 1.71 of Boost is promoted to default.

More specifically, your package fails building because it uses some
deprecated Boost.Filesystem API. The attached patch should fix the bug.

Thanks and all the best, Giovanni.
-- 
Giovanni Mascellani <g.mascell...@gmail.com>
Postdoc researcher - Université Libre de Bruxelles
From aec27618a020df16effa5819f842e7467131cdc1 Mon Sep 17 00:00:00 2001
From: Giovanni Mascellani <g...@debian.org>
Date: Sat, 11 Jan 2020 15:46:34 +0100
Subject: [PATCH] Fix compilation with Boost 1.71.

---
 ...0002-Fix-compilation-with-Boost-1.71.patch | 31 +++++++++++++++++++
 debian/patches/series                         |  1 +
 2 files changed, 32 insertions(+)
 create mode 100644 debian/patches/0002-Fix-compilation-with-Boost-1.71.patch

diff --git a/debian/patches/0002-Fix-compilation-with-Boost-1.71.patch b/debian/patches/0002-Fix-compilation-with-Boost-1.71.patch
new file mode 100644
index 0000000..0fe8348
--- /dev/null
+++ b/debian/patches/0002-Fix-compilation-with-Boost-1.71.patch
@@ -0,0 +1,31 @@
+From: Giovanni Mascellani <g...@debian.org>
+Date: Sat, 11 Jan 2020 15:44:14 +0100
+Subject: Fix compilation with Boost 1.71.
+
+Method file_string() is now obsolete and just calls string().
+---
+ src/CiftiFile.cxx | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/src/CiftiFile.cxx b/src/CiftiFile.cxx
+index 9bbb16d..6b15311 100644
+--- a/src/CiftiFile.cxx
++++ b/src/CiftiFile.cxx
+@@ -100,7 +100,7 @@ namespace
+         return QFileInfo(mypath).absoluteFilePath();
+ #else
+ #ifdef CIFTILIB_BOOST_NO_FSV3
+-	return filesystem::complete(AString_to_std_string(mypath)).file_string();
++	return filesystem::complete(AString_to_std_string(mypath)).string();
+ #else
+         return filesystem::absolute(AString_to_std_string(mypath)).native();
+ #endif
+@@ -113,7 +113,7 @@ namespace
+         return QFileInfo(mypath).canonicalFilePath();
+ #else
+ #ifdef CIFTILIB_BOOST_NO_FSV3
+-        return filesystem::complete(AString_to_std_string(mypath)).file_string();
++        return filesystem::complete(AString_to_std_string(mypath)).string();
+ #else
+ #ifdef CIFTILIB_BOOST_NO_CANONICAL
+         filesystem::path temp = AString_to_std_string(mypath);
diff --git a/debian/patches/series b/debian/patches/series
index 1348bdb..8dde55d 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
 0001-force-endian-of-datatype-example-to-make-tests-pass-.patch
+0002-Fix-compilation-with-Boost-1.71.patch
-- 
2.25.0.rc2

Attachment: ciftilib.log.gz
Description: application/gzip

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to