Control: tags 950481 + pending Dear maintainer,
I've prepared an NMU for doit (versioned as 0.31.1-3.2) and uploaded it to DELAYED/10. Please feel free to tell me if I should delay it longer. Regards. SR
diff -Nru doit-0.31.1/debian/changelog doit-0.31.1/debian/changelog --- doit-0.31.1/debian/changelog 2019-11-15 20:02:13.000000000 +0100 +++ doit-0.31.1/debian/changelog 2020-02-02 13:23:58.000000000 +0100 @@ -1,3 +1,10 @@ +doit (0.31.1-3.2) unstable; urgency=medium + + * Non-maintainer upload. + * Python 3.8 support. (Closes: #950481) + + -- Stefano Rivera <stefa...@debian.org> Sun, 02 Feb 2020 13:23:58 +0100 + doit (0.31.1-3.1) unstable; urgency=high * Non-maintainer upload. diff -Nru doit-0.31.1/debian/patches/py38 doit-0.31.1/debian/patches/py38 --- doit-0.31.1/debian/patches/py38 1970-01-01 01:00:00.000000000 +0100 +++ doit-0.31.1/debian/patches/py38 2020-02-02 13:23:58.000000000 +0100 @@ -0,0 +1,32 @@ +Description: Fix tests under Python 3.8 + Replace recursive knot with explicitly unpicklable object + . + Python 3.8 was able to pickle the previously unpicklable. Instead of relying + on limits, let's raise an explicit error. +Bug-Upstream: https://github.com/pydoit/doit/issues/341 +Bug-Debian: https://bugs.debian.org/950481 +Forwarded: https://github.com/pydoit/doit/pull/350 +--- a/tests/test_runner.py ++++ b/tests/test_runner.py +@@ -577,17 +577,12 @@ + t2 = pickle.loads(t1p) + assert 4 == t2.actions[0].py_callable() + +- @pytest.mark.xfail('PLAT_IMPL == "PyPy"') # pypy can handle it :) + def test_not_picklable_raises_InvalidTask(self): +- # create a large enough recursive obj so pickle fails +- d1 = {} +- last = d1 +- for x in range(400): +- dn = {'p': last} +- last = dn +- d1['p'] = last +- + def non_top_function(): pass ++ class Unpicklable: ++ def __getstate__(self): ++ raise pickle.PicklingError("DO NOT PICKLE") ++ d1 = Unpicklable() + t1 = Task('t1', [non_top_function, (d1,)]) + pytest.raises(InvalidTask, runner.JobTask, t1) + diff -Nru doit-0.31.1/debian/patches/series doit-0.31.1/debian/patches/series --- doit-0.31.1/debian/patches/series 2019-11-15 19:59:07.000000000 +0100 +++ doit-0.31.1/debian/patches/series 2020-02-02 13:10:15.000000000 +0100 @@ -1,2 +1,3 @@ change-pytest-fixture-syntax.patch fix-pytest-gte-4-0.patch +py38
