Hello,

On Sat 08 Feb 2020 at 12:37PM -05, Daniel Kahn Gillmor wrote:

> I don't understand what sort of rebase you are asking for -- the
> imap-dl-v2 branch on https://salsa.debian.org/dkg/mailscripts.git is
> (and been) based directly atop the imap-dl-squashed branch, so it's
> accessible with piecewise commits, with explanatory comments.
>
> But i'll send a squashed v3 patch as well :)

I looked at your branch but couldn't figure out how to get a diff of
your v2 patch against your v3 patch, which I wanted to compare against
my review comments.  Otherwise, it would definitely have been useful to
see the piecewise commits.

I'd like to suggest using branch names which correspond to versions of
the patch in the bug -- if I had seen imap-dl-v2 and imap-dl-v3 I would
have known immediately what to do.

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature

Reply via email to