Hey Lev

On 2020/06/14 18:17, Lev Lamberov wrote:
> * Package name    : foliate

An ITP for this package already exists:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=945270

Some initial work:
https://salsa.debian.org/debian/foliate

I've been meaning to get to it, but have been really busy recently, if
you'd like to finish it up please go ahead.

Here's some feedback from ftpmaster after I initially uploaded using the
version in the git repository above, which would have to be fixed for
the next upload (at least minor stuff):

"""
I do not believe that epub.js is in its preferred form of
modification.  Looking online, the presence of `var _createClass`
lines means that the file has been produced from other source files
by the JavaScript transpiler babel.  Maybe epub.js needs to be a
separate source package.  Please upload a version containing all the
source code or explain in debian/copyright why epub.js is in
fact in its preferred form of modification.

Other comments:

Looks like a bug to install to
/usr/bin/com.github.johnfactotum.Foliate rather than
/usr/bin/foliate ?

data\com.github.johnfactotum.Foliate.appdata.xml.in and
src/assets/lookup.html and other files say that project is GPL-3+
not just GPL-3

I am going to reject the package.  At the very least, if epub.js is in
the preferred form of modification, this will need to be explained in
debian/copyright, since it appears not to be the case.
"""

-Jonathan

-- 
  ⢀⣴⠾⠻⢶⣦⠀  Jonathan Carter (highvoltage) <jcc>
  ⣾⠁⢠⠒⠀⣿⡁  https://wiki.debian.org/highvoltage
  ⢿⡄⠘⠷⠚⠋   https://debian.org | https://jonathancarter.org
  ⠈⠳⣄⠀⠀⠀⠀  Debian, the universal operating system.

Reply via email to