Package: dwww
Version: 1.13.5
Severity: normal
Hi. I discovered this code in dwww-convert that doesn't make sense. Unless
I'm missing something, why test and set $mime_charset="UTF-8" again, when it's
already set that way. Perhaps you had in mind setting something else. Or
perhaps these tests are no longer needed. Something is wrong. It doesn't
affect output, rather it's just extra code which doesn't make any change in the
output.
Starts at line 504 in dwww-convert:
$mime_charset="UTF-8";
if ($file =~ /(^\/usr\/share\/doc\/[^\/]+\/)([^\/]+)$/o) {
if (($2 eq "changelog.Debian.gz") || ($2 eq "copyright") ||
($2 eq "changelog.gz" && ! -e "$1/changelog.Debian.gz")) {
$mime_charset="UTF-8";
}
}
-- System Information:
Debian Release: 10.4
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.19.0-9-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages dwww depends on:
ii apache2 [httpd-cgi] 2.4.38-3+deb10u3
ii debconf [debconf-2.0] 1.5.71
ii debianutils 4.8.6.1
ii doc-base 0.10.8
ii file 1:5.35-4+deb10u1
ii libc6 2.28-10
ii libfile-ncopy-perl 0.36-2
ii libmime-types-perl 2.17-1
ii man-db 2.8.5-2
ii mime-support 3.62
ii perl 5.28.1-6
ii sensible-utils 0.0.12
ii ucf 3.0038+nmu1
Versions of packages dwww recommends:
ii apache2 [httpd] 2.4.38-3+deb10u3
ii apt 1.8.2.1
ii dlocate 1.07+nmu1
ii info2www 1.2.2.9-24
ii swish++ 6.1.5-5
Versions of packages dwww suggests:
ii chromium [www-browser] 80.0.3987.162-1~deb10u1
ii doc-debian 6.4
ii dpkg-www 2.59
ii google-chrome-stable [www-browser] 83.0.4103.106-1
ii lynx [www-browser] 2.8.9rel.1-3
ii w3m [www-browser] 0.5.3-37
-- Configuration Files:
/etc/apache2/conf-available/dwww.conf changed [not included]
-- debconf information:
dwww/nosuchdir:
* dwww/index_docs: true
dwww/nosuchuser:
* dwww/cgidir: /usr/lib/cgi-bin
* dwww/serverport: 80
* dwww/servername: localhost
dwww/badport:
* dwww/docrootdir: /var/www/html
* dwww/cgiuser: www-data
