Bug#964111: dpkg-source: Uninitialized value $canon_pathname

[Felix Lechner]

Package: dpkg-source
Severity: minor
Tags: patch
X-Debbugs-CC: debian-lint-ma...@lists.debian.org

Hi,

The new version of dpkg-source recently caused the failures of three
Lintian tests. All had link targets pointing outside the source root,
which caused the failures, but there was an additional warning:

    Use of uninitialized value $canon_pathname in pattern match (m//)
at /usr/share/perl5/Dpkg/Source/Package.pm line 555.

Here are the tests:

    checks/files/encoding/testsuite-in-western-encoding
    checks/testsuite/national-encoding
    checks/testsuite/testsuite-general

The patch below caused the warning to disappear. Thank you for your
hard work on Dpkg.

Kind regards
Felix Lechner

* * *

--- Package.pm    2020-07-01 21:35:04.978251308 +0000
+++ /usr/share/perl5/Dpkg/Source/Package.pm    2020-07-01
21:35:42.846687621 +0000
@@ -552,6 +552,7 @@
         my $canon_newdir = realpath($newdirectory);
         my $check_symlinks = sub {
             my $canon_pathname = realpath($_);
+            return unless length $canon_pathname;
             return if $canon_pathname =~ m/^\Q$canon_newdir\E/;

             error(g_("pathname '%s' points outside source root"), $_);