On Wed, Aug 05, 2020 at 08:01:53PM +0200, Michał Mirosław wrote:
> On Sun, Aug 02, 2020 at 05:34:40PM +0300, Peter Pentchev wrote:
> > On Sun, Aug 02, 2020 at 02:02:22AM +0200, Michał Mirosław wrote:
> [...]
> > --- a/debian/tests/runtime
> > +++ b/debian/tests/runtime
> > @@ -432,6 +432,7 @@ MAIN:
> >
> > if (!defined $line) {
> > $eof->send($got_version);
> > + undef $f_out;
> > } elsif (!$got_version) {
> > if ($line =~ m{^
> > stunnel \s+
>
> I believe $f_out will not be defined here, as it only gets set after
> sub{} is created. Perl confirms this:
>
> $ TEST_STUNNEL=src/stunnel strace -f -o /tmp/log debian/tests/runtime
> Global symbol "$f_out" requires explicit package name (did you forget to
> declare "my $f_out"?) at debian/tests/runtime line 435.
> Execution of debian/tests/runtime aborted due to compilation errors.Of course you're right. Sorry about that! That's what I get for writing a patch three minutes before I have to head out and never remembering to actually test it later :( How about the attached one? G'luck, Peter -- Peter Pentchev r...@ringlet.net r...@debian.org p...@storpool.com PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13
commit eb303ad2e9c925bf7243e6877d8598d0356d68f9
Author: Peter Pentchev <r...@debian.org>
Date: Sun Aug 2 17:31:26 2020 +0300
Destroy the stunnel version watcher on EOF.
diff --git a/debian/tests/runtime b/debian/tests/runtime
index ecffe7b..f594d9a 100755
--- a/debian/tests/runtime
+++ b/debian/tests/runtime
@@ -424,7 +424,8 @@ MAIN:
my ($got_version, $before_version) = (undef, '');
my $eof = AnyEvent->condvar;
- my $f_out = AnyEvent->io(
+ my $f_out;
+ $f_out = AnyEvent->io(
fh => $s_in,
poll => 'r',
cb => sub {
@@ -432,6 +433,7 @@ MAIN:
if (!defined $line) {
$eof->send($got_version);
+ undef $f_out;
} elsif (!$got_version) {
if ($line =~ m{^
stunnel \s+
signature.asc
Description: PGP signature
