Hi. I decided to CC the FTBFS bug report so the discussion about the
`data' symbol is properly public. I hope that's OK with you.
Magnus Holmgren writes ("Re: adns package is undermaintained and needs
comaintainers"):
> Sorry for not following up on this for almost a year. I felt that I
> had to get around to it now since the version in sid/testing FTBFS
> and needs to be fixed. I'm still willing to take over
> maintainership in Debian.
That would be great.
> Tuesday 27 August 2019 at 15:14:27 CEST, Ian Jackson wrote:
> > Gianfranco, is your work in git somewhere ? I'm not sure I agree with
> > the decision to change the source package format but since I have been
> > doing little work on this package, I don't feel I ought to try to veto
> > it. I would like to hear what Magnus thinks.
>
> I'm not used to the dgit philosophy, but if I understand correctly
> the reason you don't like the quilt format is that with dgit you
> base the Debian packaging on the upstream git repository, and
> changes to the upstream source can be extracted as commits that can
> be cherry-picked. Managing quilt patch files is then redundant.
You can use whatever packaging format (including quilt) with dgit, if
you want. But I expect the upstream delta to be generally small so
quilt seems like a lot of work.
I would suggest this workflow
https://manpages.debian.org/buster/dgit/dgit-maint-merge.7.en.html
> Anyway, currently it seems that there are no changes applied in
> Debian to the upstream code, and since you are the upstream author,
> hopefully any bugs can be patched upstream before too many
> Debian-specific changes accumulate.
Yes.
> I did take a look at 1.6.0 and found that it compiles with GCC 10, but it
> removes a symbol: data.
Yes.
> That doesn't look like a symbol that should be public, though, so hopefully
> adns users depend on it and it can be safely ignored?
Indeed it should.
This symbol is public by accident and not useful to any application.
It doesn't have an appropriately namespaced name. If any application
is using it it will be accidental, and hazardous.
So IMO deleting it from the symbols file is the right fix.
Ian.
--
Ian Jackson <ijack...@chiark.greenend.org.uk> These opinions are my own.
Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.
