Hello Shengjing Zhu, Thanks for your feedback.
On Wed, Sep 16, 2020 at 10:56:08PM +0800, Shengjing Zhu wrote: > On Wed, Sep 16, 2020 at 5:33 PM Andreas Henriksson <andr...@fatal.se> wrote: [...] > > * Package name : golang-gopkg-cheggaaa-pb.v3 [...] > This package uses a very strange version approach. > > In short, v3 is not really v3. > > The master branch contains both v1 and v3 code. Right now that's true, but I wonder for how long. My guess is that it's set up like this so that both the old gopkg.in/cheggaaa/pb.v1 import path and then new github.com/cheggaaa/pb/v3 import paths both works. (Leaving v2 in the cold.) I assume at some point upstream don't want to deal with v1 anymore and will just drop it from the master branch. > v3 code is lived in a directory called v3, see > https://github.com/cheggaaa/pb/tree/master/v3 > > So basically, we can reuse the v1 source package, v1 and v3 can live > together... I'm a bit worried what will happen if we do this and then upstream drops v1.... Also what version number to use for it? There are 1.x and 3.x releases being done in parallell. Also what about the different import paths? github vs gopkg? > And maybe we can add a transitional package to avoid confusion. An alternative might be to just do v3 completely separate and if we really want to avoid it containing a duplicate v1 we could just do `Files-Excluded: ./*.go` on whatever. I however don't see any real issue with just leaving it in (possibly without installing the files in the binary -dev package). The copyright review for it all is trivial. Would very much appreciate help with creating a package for it however that person wants to set it up. :) Regards, Andreas Henriksson
