Hi Nilesh,

On Wed, Mar 17, 2021 at 10:31:37PM +0530, Nilesh Patra wrote:
> +--- a/Makefile
> ++++ b/Makefile
> +@@ -53,7 +53,7 @@
> +     ./maketab >proctab.c
> + 
> + maketab:    ytab.h maketab.c
> +-    $(CC) $(CFLAGS) $(CPPFLAGS) maketab.c -o maketab $(LDFLAGS)
> ++    $(CC_FOR_BUILD) $(CFLAGS) $(CPPFLAGS) maketab.c -o maketab $(LDFLAGS)

This change breaks the upstream build as CC_FOR_BUILD is never
initialized. You should add

    CC_FOR_BUILD ?= $(CC)

to make the patch upstreamable.

Helmut

Reply via email to