Control: tags -1 confirmed moreinfo Hi,
On Tue, Apr 13, 2021 at 06:46:57PM +0200, Julian Andres Klode wrote: > [ Reason ] > > Fix downloading packages from repositories without a Size field; those > fail if the unsized package is the largest one on the server that's in > the pipeline. > > Add warnings for such repositories, to actually surface such > repositories. > > We also fix a unit test to not trigger a test failure and hence FTBFS. > This only got triggered on Ubuntu's LTO toolchain so far, but is an > actual bug - it's unclear why we haven't seen it before. > > [ Impact ] > > Repositories without Size fields, such as those generated by pulp, > will have failing downloads. > > Without the warning, users will have no clear deprecation, and the error > in 2.3.y that will land in bookworm will be hard on them. > > The test case fix should not have any impact on bullseye; well it > _should_ not have worked before. It's mostly there for other > downstreams, but I can't rule out the possibility of it triggering at > some point after a toolchain update or by luck or whatever :D > > [ Tests ] > > We have added automatic integration tests for the unsized package > stuff; and the unit test is well a unit test itself. > > [ Risks ] > > CI that checks for APT warnings will fail on broken repositories, as > they'll get the warning :) > > The maximum pipeline size now being calculated correctly for unsized > packages should not cause any issue, as that could have returned 0 > (unknown) before already; though in practice, most times, you don't end > up with packages with unknown size. > > If you don't have a repo without a Size field, there should be no risk, > as none of the code paths should be triggered. > > [ Checklist ] > [x] all changes are documented in the d/changelog > [x] I reviewed all changes and I approve them > [x] attach debdiff against the package in testing > > [ Other info ] > > unblock apt/2.2.3 Please go ahead with the upload and remove the moreinfo tag from this bug once the package is ready to migrate. Thanks, Ivo