On Tue, 16 Nov 2021 01:30:55 +1100 Stuart Prescott <stu...@debian.org> wrote:
> Hi Scott & Tobias
> 
> On Monday, 15 November 2021 21:13:09 AEDT Dr. Tobias Quathamer wrote:
> > On Sun, 14 Nov 2021 20:30:06 -0500 Scott Kitterman <sc...@kitterman.com>
> > 
> > wrote:
> > > I looked at this a bit today and it looks like the test failures are due
> > > to
> > > updates in the iso-codes data used by the tests, not any real failures.  I
> > > think disabling the failing tests for now would be a reasonable way to
> > > keep
> > > this in testing (I'm interested to avoid transitive removal of xml2rfc).
> > > 
> > > Unless there's some objection to this, I will probably NMU later in the
> > > week.
> > > 
> > > Scott K
> > 
> > Hi Scott,
> > 
> > iso-codes maintainer here -- I've just seen this bug and your mail. Your
> > analysis is correct, from my point of view, you should go ahead with the
> > NMU.
> 
> The tests look easy enough to fix, so it's worth trying to do that. (and it's 
> in the Debian group on salsa to make that easy :)
> 
> I'm a bit surprised by some of the data changes though -- apparently England 
> is no longer a part of the UK. Yes, that's quite complicated, but the 
> ISO-3166-2 info does still list ENG and EAW. As the pycountry tests 
> highlight, 
> those divisions disappeared from iso_3166-2.json with the switch over to a 
> different data harvester.
> 
> https://www.iso.org/obp/ui/#iso:code:3166:GB 
> 
> Is that correct and intended?

Good question.  I not sure how to adapt one test to the new data, so I'll leave 
it on to you to deal with.  Please address this before it gets auto-removed.

Scott K

Reply via email to