Source: network-manager-iodine Version: 1.2.0-3.1 Severity: wishlist Tags: patch
Hi, currently, nm-iodine-service.name.in uses auth-dialog=nm-iodine-auth-dialog This means, other programs like nm-connection-editor need to have the same compiled in search path (libexecdir) as network-manager-iodine. There has been a request that I change the libexecdir of NetworkManager (and related packages) from /usr/lib/NetworkManager to /usr/libexec. Doing that, would break network-manager-iodine, so I'd like network-manager-iodine use an absolute path for auth-dialog. This way, affected packages can be changed independently to /usr/libexec without breaking. I'm considering making this change in NetworkManager in bookworm+1, so it would be great to have a fixed network-manager-iodine package in bookworm, to make future backports easier. Thanks for considering the attached patch. I can offer to NMU, fwiw. Regards, Michael -- System Information: Debian Release: bookworm/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 6.0.0-6-amd64 (SMP w/4 CPU threads; PREEMPT) Kernel taint flags: TAINT_FIRMWARE_WORKAROUND Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled
From: Michael Biebl <bi...@debian.org> Date: Mon, 19 Dec 2022 11:49:24 +0100 Subject: Use full path to auth-dialog in service file This way we avoid that the search path compiled into other packages, like network-manager-gnome, need to match our own libexecdir configure parameter. --- nm-iodine-service.name.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nm-iodine-service.name.in b/nm-iodine-service.name.in index 4061b43..cf024a3 100644 --- a/nm-iodine-service.name.in +++ b/nm-iodine-service.name.in @@ -7,6 +7,6 @@ program=@LIBEXECDIR@/nm-iodine-service plugin=@PLUGINDIR@/libnm-vpn-plugin-iodine.so [GNOME] -auth-dialog=nm-iodine-auth-dialog +auth-dialog=@LIBEXECDIR@/nm-iodine-auth-dialog properties=libnm-iodine-properties supports-external-ui-mode=true
