Hi, On Mon, May 11, 2020 at 12:08:30PM +0200, Guido Günther wrote: > Hi, > On Mon, May 11, 2020 at 11:13:20AM +0200, Matthijs Kooijman wrote: > > Package: git-buildpackage > > Followup-For: Bug #959665 > > > > Hi, > > > > It does seem that having a full stop at the end of debian/changelogs is > > conventional. However, this is already easy to configure locally. I had > > this in my debian/gbp.conf for a long time: > > > > [import-orig] > > import-msg = New upstream release %(version)s. > > > > I've since removed the dot again, since for *git* commit messages, it is > > conventional to *not* have a full stop at the end of the first line and > > I kept forgetting to add it for my Debian packages, so now my changelogs > > also omit the full stop. > > > > Also, it seems that Debian policy does not mention the full stop at all: > > https://www.debian.org/doc/debian-policy/ch-source.html#debian-changelog-debian-changelog > > > > Anyway, this is already easy to configure, so I wonder if this would be > > worth changing? > > That's what i'm unsure about too and the reason i was asking for the > pattern behind this. I'm leaning more to leave things as is for the > moment too - so thanks for your input!
Note that gbp dch already figures out if a dot is needed based on the commit body so the git commit message goes without a dot while the changelog entry gets a dot in multiline messages (See terminate_first_line_if_needed) if the body starts with a capital letter. The only thing needed would be to make it act on one line messages at all - either by adding yet another option or by reaching consensus. Policy section 4.4. Debian changelog: "debian/changelog" does not make any recommendations along these lines. Cheers, -- Guido
