Hi Cyril, On Tue, Apr 25, 2023 at 06:05:04PM +0200, Cyril Brulebois wrote: > Control: tag -1 patch pending > > Andreas Henriksson <andr...@fatal.se> (2023-04-11): > > The culprit seems to be the wrong path hardcoded at: > > https://sources.debian.org/src/zcfan/1.2.1-1/Makefile/#L44 > > > > Preferably you would find out this path by querying systemd.pc for it, > > ie. pkg-config --variable=systemdsystemunitdir systemd > > > > (Note: You'll also need to build-dep on pkg-config and systemd, for > > systemd.pc) > > Let's… not do that during the hard freeze. > > With the attached patch, the resulting binary debdiff looks like this: > > [The following lists of changes regard files as different if they have > different names, permissions or owners.] > > Files in second .deb but not in first > ------------------------------------- > -rw-r--r-- root/root /lib/systemd/system/zcfan.service > -rwxr-xr-x root/root DEBIAN/postinst > -rwxr-xr-x root/root DEBIAN/postrm > -rwxr-xr-x root/root DEBIAN/prerm > > Files in first .deb but not in second > ------------------------------------- > -rw-r--r-- root/root /usr/lib/systemd/system/zcfan.service > (*) -rw-r--r-- root/root /usr/share/doc/zcfan/changelog.Debian.amd64.gz > > Control files: lines which differ (wdiff format) > ------------------------------------------------ > Installed-Size: [-36-] {+39+} > (*) [-Source: zcfan (1.2.1-1)-] > Version: [-1.2.1-1+b1-] {+1.2.1-2+} > > There's a bit of extra noise in there, due to the fact we're comparing a > binNMU against a normal upload, I've prefixed relevant lines with an > asterisk. > > > Maintainer: I'm uploading to DELAYED/5, it can be either rescheduled to > DELAYED/0 if you're happy with the changes right now, or be superseded > by an upload of yours if that happens before the delay is over. > Apologies for the delay, but I've uploaded a -2 that works around dh_installsystemd not recognizing files in /usr/lib/systemd by moving it to /lib/systemd, invoking dh_installsystemd, and moving it back to /usr/lib/systemd
Let me know if that is acceptable - otherwise the changes in -1+b1 looks fine too. Thanks, -- Michel Alexandre Salim identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2
signature.asc
Description: PGP signature
