On Wed, Jun 14, 2023 at 06:20:44PM +0100, Adam D. Barratt wrote:
> On Wed, 2023-06-14 at 17:27 +0200, Marc Haber wrote:
> > this pre-upload request for the aide package is filed to ask for
> > guidance whether this package is suitable for bookworm-updates.
>
> Do you actually mean bookworm-updates here (i.e. pushed to users in
> advance of 12.1), or simply (bookworm-)proposed-updates, therefore
> reaching users with the release of 12.1?
I would be fine with either, proposed-updates of course being less
invasive. Probably a misunderstanding because of me being too stupidto
find the docs. I'll read up on what you linked to me.
> I'd be interested in seeing a binary debdiff (for an arbitrary
> architecture) with "--controlfiles=ALL" to see the changes made to the
> maintainer scripts, but overall I think this looks OK.
aide-dynamic:
1 [23/4887]mh@salida:~/packages/aide $ debdiff --controlfiles=ALL
20230614/aide-dynamic_0.18.3-1_all.deb
build-area/aide-dynamic_0.18.3-1+deb12u1_all.deb
File lists identical (after any substitutions)
Control files: lines which differ (wdiff format)
------------------------------------------------
Recommends: aide-common (= [-0.18.3-1)-] {+0.18.3-1+deb12u1)+}
Version: [-0.18.3-1-] {+0.18.3-1+deb12u1+}
1 [24/4888]mh@salida:~/packages/aide $
aide:
[19/4883]mh@salida:~/packages/aide $ debdiff --controlfiles=ALL
20230614/aide_0.18.3-1_amd64.deb
build-area/aide_0.18.3-1+deb12u1_amd64.deb
File lists identical (after any substitutions)
Control files: lines which differ (wdiff format)
------------------------------------------------
Installed-Size: [-289-] {+293+}
Recommends: aide-common (= [-0.18.3-1)-] {+0.18.3-1+deb12u1)+}
Version: [-0.18.3-1-] {+0.18.3-1+deb12u1+}
1 [20/4884]mh@salida:~/packages/aide $
aide-common is attached.
>
> One small comment:
>
> +if dpkg --compare-versions "$2" le 0.18.3-1; then
> + # we're updating from 0.18-3 or earlier, chown aideinit logs
>
> That should presumably be "from 0.18.3".
Yes. fixed in git and master. Thanks for spotting this.
Greetings
Marc
--
-----------------------------------------------------------------------------
Marc Haber | "I don't trust Computers. They | Mailadresse im Header
Leimen, Germany | lose things." Winona Ryder | Fon: *49 6224 1600402
Nordisch by Nature | How to make an American Quilt | Fax: *49 6224 1600421
[The following lists of changes regard files as different if they have
different names, permissions or owners.]
Files in second .deb but not in first
-------------------------------------
-rw-r--r-- root/root /usr/lib/sysusers.d/aide-common.conf
No differences were encountered between the config files
Control files: lines which differ (wdiff format)
------------------------------------------------
Depends: aide (>= 0.17), liblockfile1, ucf (>= 2.0020), debconf (>= 0.5) |
[-debconf-2.0-] {+debconf-2.0, systemd | systemd-standalone-sysusers |
systemd-sysusers+}
Installed-Size: [-449-] {+451+}
Version: [-0.18.3-1-] {+0.18.3-1+deb12u1+}
Postinst files: lines which differ (wdiff format)
-------------------------------------------------
[-if dpkg --compare-versions "$2" lt 0.17.5-1; then-]
[- # we're updating from a version earlier than 0.17.5, chown logs-]
[- # and databases-]
[- chown --quiet _aide:adm /var/log/aide /var/log/aide/aide.log
/var/log/aide/aide.log.* || true-]
[- chmod --quiet 2755 /var/log/aide || true-]
[- chown --quiet _aide:root /var/lib/aide/aide.db /var/lib/aide/aide.db.new
|| true-]
[-fi-]
[-if dpkg --compare-versions "$2" lt 0.18-3; then-]
[- # we're updating from a version earlier than 0.18-3, chown aideinit logs-]
[- chown --quiet _aide:adm /var/log/aide/aideinit.log
/var/log/aide/aideinit.errors|| true-]
[-fi-]
# Automatically added by {+dh_installsysusers/13.11.4+}
{+if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" =
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then+}
{+ systemd-sysusers ${DPKG_ROOT:+--root="$DPKG_ROOT"} aide-common.conf+}
{+fi+}
{+# End automatically added section+}
{+# Automatically added by+} dh_installtmpfiles/13.11.4
{+# this needs to be after debhelper, otherwise the account doesn't+}
{+# yet exist.+}
{+if dpkg --compare-versions "$2" lt 0.17.5-1; then+}
{+ # we're updating from a version earlier than 0.17.5, chown logs+}
{+ # and databases+}
{+ chown --quiet _aide:adm /var/log/aide /var/log/aide/aide.log
/var/log/aide/aide.log.* || true+}
{+ chmod --quiet 2755 /var/log/aide || true+}
{+ chown --quiet _aide:root /var/lib/aide/aide.db /var/lib/aide/aide.db.new
|| true+}
{+fi+}
{+if dpkg --compare-versions "$2" le 0.18.3-1; then+}
{+ # we're updating from 0.18-3 or earlier, chown aideinit logs+}
{+ chown --quiet _aide:adm /var/log/aide/aideinit.log
/var/log/aide/aideinit.errors|| true+}
{+fi+}
No differences were encountered between the postrm files
No differences were encountered between the prerm files
No differences were encountered between the templates files
