Control: tags -1 moreinfo Hi Marc,
On Fri, Oct 06, 2023 at 03:03:02PM +0200, Marc Leeman wrote: > Package: sponsorship-requests > * Package name : openvpn3-client > Version : 20+dfsg-1 > Upstream contact : OpenVPN Solutions LLC <i...@openvpn.net> > * URL : https://openvpn.net/ > * License : Gnu Affero General Public License 3 > * Vcs : https://salsa.debian.org/televic-team/openvpn3-client > Section : net > (...) > > openvpn3-client (20+dfsg-1) unstable; urgency=medium > . > * Initial release. (Closes: #904044) > * d/control: do not depend on openvpn2 dev headers > * d/postinst: create user before chown > * d/README: add comment on lintian-warning unicode-impl.hpp > * d/README: update dfsg motivation > * remove sum files (see d/README.source) > > Additional discussion on the packaging with upstream can be found here: > https://github.com/OpenVPN/openvpn3-linux/issues/193 The issue and ITP talks about there being two packages, a library part and the client part. Has this changed (I cannot find the library part.) - changelog for an initial release should be only the first line, (as there are no changes to the debian package on the initial upload) - you are creating an user. [1] - As per Debian polic 9.3, the username shouldbe an invalid user and start with an "_" - If I am not mistaken, you can use tmpfiles.d to specify the directory /var/lib/openvpn to be owned by openvpn:openvpn, so that snipped in postinst might not be needed. (please verify) [1] https://wiki.debian.org/AccountHandlingInMaintainerScripts - unicode-impl.hpp I'm not convinced that this (license) issue is a non-issue. It might be solved in later versions of the file, but the version in the tarball does not allow modification. As you are anyway dfsg repacking (at least the version indicates this, see also below), hows' about removing the file and then reintroducing a fine one with a patch? - files installed in /usr/include --> you want a -dev package. - d/copyright - is not DEP-5 format. - There is no indication why it is dfsg, and there id no Files-Exluded section.. so are you repacking at all? - For praticality reasons, it is recommended to keep the license of the debian the same as upstream. Otherwise, package upstreaming might get more difficult than needed. (GPL2 is anyway incompatibel with Affero GPL 3; your "or later" safes the day.) - There is license text for the Gnu Affero General Public License 3, and it should be probably "AGPL-3" abbreviated. - Note: I did not do a license review of the source files. - lintian overrides - you need to comment the overrides WHY you overrode them. - postinst - remove the useless comment about utf-8, or let me know what you want to say with it. - the python part - I think this should be in a dedicated python module package? - S-V could be updated. - There is no watch file. - The package is in a team namespace on salsa, but d/control does not indicate that it is team maintained. As usual, remove moreinfo when you are done updating your package. Cheers, -- tobi
