Control: forwarded -1 https://github.com/libsdl-org/sdl12-compat/pull/326
Control: tags -1 + upstream

On Sun, 31 Dec 2023 at 10:18:15 +0100, Helmut Grohne wrote:
> ltris fails to cross build from source, because it uses the build
> architecture pkg-config. Surprising thing: It doesn't actually mention
> pkg-config anywhere. Turns out, it uses SDL_CONFIG, which happens to
> expand to "pkg-config sdl" and this is wrong. I'm attaching a patch to
> fix that for your convenience.

Forwarded to https://github.com/libsdl-org/sdl12-compat/pull/326, with the
addition of a serial number increment and an explanatory commit message.

Because of the way Autoconf macros get vendored into dependent projects
and versioned by their serial number, I think we should get this fixed
upstream first, and then backport that fix into Debian. Otherwise,
it will be ineffective for projects that already include a sdl.m4 with
serial 2 in their source releases.

> I believe that libsdl2-dev has the same bug. Would you mind fixing it
> there as well? I am not aware of any package using sdl2-config instead
> of sdl2.pc though.

I've proposed https://github.com/libsdl-org/SDL/pull/8766 as the
equivalent change. Again, we should do that upstream first, but then it
can be backported.

The good news is that SDL3 doesn't need this, because SDL3 relies on
standard pkg-config (and/or CMake) mechanisms instead of providing its
own custom Autoconf macros.

Thanks,
    smcv

Reply via email to