tags 1066248 +patch
thanks
The functions in question are defined in
src/librnd/plugins/hid_lesstif/dialogs.c
and used in src/librnd/plugins/hid_lesstif/main.c
My first attempt at fixing the issue was to declare the functions in
dialogs.h
and include dialogs.h in main.c, however doing so caused errors with
conflicting type definitions, so I just defined them directly in main.c
instead.
while working on this issue I discovered that the clean target was not
cleaning up properly, so I fixed that too.
A debdiff is attatched.
Review and upload would be appreciated since this blocks the time_t
transition
diff -Nru librnd-4.1.1/debian/changelog librnd-4.1.1/debian/changelog
--- librnd-4.1.1/debian/changelog 2024-02-28 17:20:34.000000000 +0000
+++ librnd-4.1.1/debian/changelog 2024-04-02 04:43:46.000000000 +0000
@@ -1,3 +1,11 @@
+librnd (4.1.1-1.2) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Add missing function declarations.
+ * Fix clean target.
+
+ -- Peter Michael Green <plugw...@debian.org> Tue, 02 Apr 2024 04:43:46 +0000
+
librnd (4.1.1-1.1) unstable; urgency=medium
* Non-maintainer upload.
diff -Nru librnd-4.1.1/debian/patches/add-missing-function-declaration.patch
librnd-4.1.1/debian/patches/add-missing-function-declaration.patch
--- librnd-4.1.1/debian/patches/add-missing-function-declaration.patch
1970-01-01 00:00:00.000000000 +0000
+++ librnd-4.1.1/debian/patches/add-missing-function-declaration.patch
2024-04-02 04:42:54.000000000 +0000
@@ -0,0 +1,14 @@
+Index: librnd-4.1.1/src/librnd/plugins/hid_lesstif/main.c
+===================================================================
+--- librnd-4.1.1.orig/src/librnd/plugins/hid_lesstif/main.c
++++ librnd-4.1.1/src/librnd/plugins/hid_lesstif/main.c
+@@ -51,6 +51,9 @@
+
+ #include <sys/poll.h>
+
++void lesstif_attr_dlg_free_all(void);
++void lesstif_attr_sub_update_hidlib(void *hid_ctx, rnd_design_t *new_dsg);
++
+ const char *lesstif_cookie = "lesstif HID";
+
+ rnd_design_t *ltf_hidlib;
diff -Nru librnd-4.1.1/debian/patches/series librnd-4.1.1/debian/patches/series
--- librnd-4.1.1/debian/patches/series 2024-01-13 09:12:54.000000000 +0000
+++ librnd-4.1.1/debian/patches/series 2024-04-02 04:21:58.000000000 +0000
@@ -0,0 +1 @@
+add-missing-function-declaration.patch
diff -Nru librnd-4.1.1/debian/rules librnd-4.1.1/debian/rules
--- librnd-4.1.1/debian/rules 2024-01-13 09:12:54.000000000 +0000
+++ librnd-4.1.1/debian/rules 2024-04-02 04:43:46.000000000 +0000
@@ -21,6 +21,10 @@
override_dh_auto_clean:
# only try to run dh_auto_clean if configure has been run
test -f Makefile.conf && dh_auto_clean || true
+ find . -name *.o -delete
+ find . -name *.so.* -delete
+ rm -f scconfig/aru
+ rm -f doc/conf/tree/editor_global_grid.html
doc/conf/tree/editor_local_grid.html src/librnd/plugins/lib_hid_gl/draw_INIT.h
src/librnd/poly/polyconf.h src/librnd/polybool/polyconf.h
override_dh_auto_configure:
./configure \
