On 02/05/2024 12:14, Daniel Reichelt wrote:
Hi Roland, > On 20/04/2024 13:32, Daniel Reichelt wrote: > What are you doing that makes the directory 'config/includes.binary' > disappear? > If I use 'lb config --distribution sid', the directory is created (but > empty) and there will be no error message.I'm keeping my (final, i.e. `lb config`ured) config-trees in git which has beenworking for over a decade so far.
Ah, that's a known feature of git: it does not store empty directories (therefore often a hidden file .gitkeep or .gitignore is used [1])
> the directory is created (but empty) and there will be no error > message. It is not a good practise to depend on the existence of empty directories, IMHO. Your commit message says nothing abaout the patch in scripts/build/binary_includes. Why did you move those lines in the first place?
I placed a hidden directory in it (.disk), and that could not be found by 'Find_files', so I shifted things around. All my test scenarios are a combination of 'lb config' and 'lb build', so I couldn't see an issue with the missing directory in my local tests.
I'll prepare a proper fix that detects whether the directory is present. With kind regards, Roland[1] https://stackoverflow.com/questions/7229885/what-are-the-differences-between-gitignore-and-gitkeep
OpenPGP_signature.asc
Description: OpenPGP digital signature
