On Thu, Oct 01, 2009 at 12:11:52PM +0300, Yavor Doganov wrote:
> В 08:05 +0200 на 01.10.2009 (чт), Mike Hommey написа:
> > Then it should not have crashed, but only failed to start.
>
> Xulrunner is not initialized at browser startup, but only when you open
> a new tab and start loading something, or via Preferences->Browser when
> the rendering engines are checked.
>
> > Or maybe kazehakase doesn't properly handle the GRE glue failure
> > cases.
>
> You are right, indeed -- the return value of `xulrunner_init' is never
> checked, so that's why the user is greeted with SIGSEGV. What would be
> the appropriate thing to do? Something like this:
>
> G_MODULE_EXPORT void
> KZ_MODULE_IMPL_INIT (GTypeModule *module)
> {
> #ifdef XPCOM_GLUE
> - xulrunner_init();
> + if (xulrunner_init() == FALSE)
> + {
> + g_printerr(_("Failed to initialize Gecko.\n"));
> + exit(EXIT_FAILURE);
> + }
> ...
>
> ?
I would say that something that presents a popup to the user would be
better, but your solution should also work.
Mike
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
