Dmitry, I've looked at the changes you've made (haven't actually tested yet though) One thing I've noticed so far is that you've made 100% an error. IMO it is a reasonable request and means that the user wants the entire virtual drive to filled up using the percentage by percentage method rather than the maximum free space method.
Robert. -----Original Message----- From: Dmitry E. Oboukhov [mailto:un...@debian.org] Sent: 13 July 2010 12:29 To: Robert de Bath; 588...@bugs.debian.org Cc: cont...@bugs.debian.org Subject: [NOTWHITELIST] Re: Bug#588892: Doesn't follow filesystem recommendations severity 588892 minor tags 588892 patch thanks Hi, Robert! I've edited Your patch a bit and uploaded new version upto Debian/experimental. Please test it :) Thanks for Your work! On 09:40 Tue 13 Jul , Robert de Bath wrote: RdB> Package: mhddfs RdB> Version: 0.1.35 RdB> Severity: minor RdB> Tags: patch RdB> When filling a filesystem mhddfs will normally fill one of the component filesystems to a fixed amount less than the total capacity of the filesystem before it moves onto the next. If the filesystems have different capacities the percentage of free space remaining cannot be forced into the range suggested at the maximum by the filesystem writers. Eg. If you arrange for the free space on one drive to be 25% of the capacity a drive of half the capacity will end up at 50% and a drive of double will end up at 12%. The default value mean that a modern hard disk will be filled up to 100% before moving onto the next drive. RdB> The attached patch uses a free percentage calculation so that the drives will be filled one by one as now, but to a free percentage before moving onto the next drive. Once all the drives have been filled to this percentage the drive space will be allocated to the drive with the minimum allocated (integer) percentage. The use of an integer means that related files are likely to be clustered on the same drive as subsequent files will be placed on the same drive until the percentage value ticks over to the next integer value. RdB> This has several advantages; the simplest being that a default setup of (say) 25% is good for all drives. Others are all the reasons for keeping a filesystem under 85% usage in the first place. RdB> I have chosen 25% free as the default because it gives a good headroom to go buy an extra drive before you hit the 85% I mentioned before. RdB> Robert de Bath RdB> rdeb...@tvisiontech.co.uk -- ... mpd playing: U.D.O. - The Key . ''`. Dmitry E. Oboukhov : :’ : email: un...@debian.org jabber://un...@uvw.ru `. `~’ GPGKey: 1024D / F8E26537 2006-11-21 `- 1B23 D4F8 8EC0 D902 0555 E438 AB8C 00CF F8E2 6537
