Hi

On Wed, Sep 08, 2010 at 09:37:46PM +0200, Salvatore Bonaccorso wrote:
> Hi Martin
> 
> Not yet tested: Would the attached debdiff solve the issue? 
> 
> Even we have the alternate dependency, test first if /sbin/MAKEDEV is
> executable, and only the run it. And even it this fails, then return
> true. It is done in simlilar way in mcelog package.
> 
> Bests
> Salvatore

> diff -u vtun-3.0.2/debian/postinst vtun-3.0.2/debian/postinst
> --- vtun-3.0.2/debian/postinst
> +++ vtun-3.0.2/debian/postinst
> @@ -24,8 +24,12 @@
>          if [ ! -e /dev/.udev ] && [ ! -e /dev/.udevdb ] && \
>              [ ! -e /dev/net/tun ]; then
>              echo -n "Creating /dev/net/tun with default MAKEDEV permissions: 
> "
> -            (cd /dev; /sbin/MAKEDEV tun)
> -            echo "done."
> +            if [ -x /sbin/MAKEDEV ]; then
> +                (cd /dev && /sbin/MAKEDEV tun) || true
> +                echo "done."
> +            else
> +                echo "not created."
> +            fi
>          fi
>      ;;
>  
> diff -u vtun-3.0.2/debian/changelog vtun-3.0.2/debian/changelog
> --- vtun-3.0.2/debian/changelog
> +++ vtun-3.0.2/debian/changelog
> @@ -1,3 +1,11 @@
> +vtun (3.0.2-3.1) unstable; urgency=low
> +
> +  * Non-maintainer upload.
> +  * Create /dev/tun in postinst only if /sbin/MAKEDEV is executable
> +    (Closes: #595931).
> +
> + -- Salvatore Bonaccorso <salvatore.bonacco...@gmail.com>  Wed, 08 Sep 2010 
> 21:24:22 +0200
> +
>  vtun (3.0.2-3) unstable; urgency=low
>  
>    * Stop installing deprecated modutils conffile. (Closes: #518314).

Ok, tested now in a chroot:

  Reading package lists...
  Building dependency tree...
  Correcting dependencies... Done
  The following extra packages will be installed:
    liblzo2-2 libssl0.9.8 libudev0 udev
  Recommended packages:
    usbutils pciutils
  The following NEW packages will be installed:
    liblzo2-2 libssl0.9.8 libudev0 udev
  0 upgraded, 4 newly installed, 0 to remove and 0 not upgraded.
  1 not fully installed or removed.
  Need to get 1600kB of archives.
  After this operation, 4239kB of additional disk space will be used.
  Get:1 http://ftp.ch.debian.org/debian/ sid/main liblzo2-2 amd64 2.03-2 
[59.6kB]
  Get:2 http://ftp.ch.debian.org/debian/ sid/main libssl0.9.8 amd64 0.9.8o-2 
[945kB]
  Get:3 http://ftp.ch.debian.org/debian/ sid/main libudev0 amd64 161-1 [113kB]
  Get:4 http://ftp.ch.debian.org/debian/ sid/main udev amd64 161-1 [482kB]
  debconf: delaying package configuration, since apt-utils is not installed
  Fetched 1600kB in 1s (1574kB/s)
  Selecting previously deselected package liblzo2-2.
  (Reading database ... 6116 files and directories currently installed.)
  Unpacking liblzo2-2 (from .../liblzo2-2_2.03-2_amd64.deb) ...
  Selecting previously deselected package libssl0.9.8.
  Unpacking libssl0.9.8 (from .../libssl0.9.8_0.9.8o-2_amd64.deb) ...
  Selecting previously deselected package libudev0.
  Unpacking libudev0 (from .../libudev0_161-1_amd64.deb) ...
  Selecting previously deselected package udev.
  Unpacking udev (from .../archives/udev_161-1_amd64.deb) ...
  Setting up liblzo2-2 (2.03-2) ...
  Setting up libssl0.9.8 (0.9.8o-2) ...
  Setting up libudev0 (161-1) ...
  Setting up udev (161-1) ...
  A chroot environment has been detected, udev not started.
  Setting up vtun (3.0.2-3.1) ...
  Creating /dev/net/tun with default MAKEDEV permissions: not created.
  update-rc.d: warning: vtun stop runlevel arguments (0 1 6) do not match LSB 
Default-Stop values (none)

So it installs udev, does not start it as we are in a chroot
environment and thus as /sbin/MAKEDEV is not present here, does not
create the tun device.

Maybee the above patch could be done better and improved. 

Bests
Salvatore

Attachment: signature.asc
Description: Digital signature

Reply via email to