Raphael Hertzog wrote: > On Mon, 03 Jan 2011, Bastian Blank wrote: >> Unified diff files are applied from the start to the end, file by file. >> There is no notion of duplicate files in it. > > While such files are valid patch files, "diff" will never generate such a > patch. So it's a sign either of a mistake or of a somewhat manually > crafted diff.. I think it's best to be on the safe side and error out.
Presumably in this case the patch was taken from upstream (which makes it easier to verify that it is well tested). I suppose that is not too important given tools like interdiff, though. > This restriction exists since forever in dpkg-source, it was applied > in .diff.gz files and it's thus now also applied on quilt patches. On the other hand, do these concatenated patches break anything? If not, I think it makes sense to accept them; if so, please keep rejecting them. :) Just my two cents. Jonathan -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
