Le Mon, Dec 12, 2011 at 06:58:00PM +0100, Andreas Tille a écrit : > Hi Charles, > > any reason to not apply this patch and fix the bug?
Hi Andreas and Clint, to cut a long story short: 1) the bad reason: spending too much time on DEP 5. 2) the technical reason: I do not understand the problem well enough. 3) the logistic reason: I think we need unblock the update to 6.4.0 first. The patch changes upstream files, to ensure proper linkage in Ubuntu. I do not know well enough the difference between Ubuntu and Debian to understand why this patch is needed there and not here. I would appreciate more detailed explanations. It would also be optimum to propose this patch upstream directly, so that we do not need to implement autoreconf steps, and so that we are sure it has been accepted by experts. What I miss in particular for submitting Upstream is explanation of the changes in the mysql.m4 file. Is it that the original did not follow best practices ? If yes, which ones; is there a doc somewhere to show to the upstream developers ? > > --- emboss-6.3.1.orig/debian/patches/fix-mysql-macro.patch > > +++ emboss-6.3.1/debian/patches/fix-mysql-macro.patch > > @@ -0,0 +1,25 @@ > > +Index: emboss-6.3.1/m4/mysql.m4 > > +=================================================================== > > +--- emboss-6.3.1.orig/m4/mysql.m4 2010-05-18 15:12:06.000000000 -0700 > > ++++ emboss-6.3.1/m4/mysql.m4 2011-11-27 17:06:21.622474403 -0800 > > +@@ -95,9 +95,9 @@ > > + dnl not be installed > > + > > + EMBCFLAGS=$CFLAGS > > +- EMBLDFLAGS=$LDFLAGS > > ++ EMBLIBS=$LIBS > > + CFLAGS=$MYSQL_CFLAGS > > +- LDFLAGS=$MYSQL_LDFLAGS > > ++ LIBS=$MYSQL_LDFLAGS > > + > > + AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <stdio.h> > > + #include "mysql.h"]], > > +@@ -106,7 +106,7 @@ > > + [havemysql=no]) > > + > > + CFLAGS=$EMBCFLAGS > > +- LDFLAGS=$EMBLDFLAGS > > ++ LIBS=$EMBLIBS > > + > > + if test "$havemysql" = yes; then > > + AC_DEFINE([HAVE_MYSQL], [1], I would like to learn from that patch; I can not apply it blindly. By the way, I really would like to solve the problem with 6.4.0 and its non-free files. But I have postponed this work until I manage to update picard-tools, and it has eaten countless hours of my time without much public output, because of its reverse-dependancy on a java wrapper for a C library (snappy-java). Luckily Upstream is very supportive. Have a nice day, -- Charles Plessy Debian Med packaging team, http://www.debian.org/devel/debian-med Tsurumi, Kanagawa, Japan -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
