Bug#317864: FTBFS: Jumps into statement expression

[Matt Kraai]

Package: baycomusb
Version: 0.10-4
Severity: serious
Tags: patch

baycomusb fails to build because it contains some jumps into statement
expressions:

gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 
-I/usr/lib/glib/include -I/usr/include/gnome-xml -DCONFIGDIR=\"/usr/etc\" 
-DLOCALSTATEDIR=\"/usr/var\"  -I.. -I../misc -I../usbdrv -I../diag    
-I../directx/include -I../directx/include/directx6 -I../kerneldrv -I../wdmdrv   
 -O2 -g -Wall -c adapttests.c
adapttests.c: In function 'hdlc_receive':
adapttests.c:441: error: jump into statement expression
adapttests.c:441: error: jump into statement expression
adapttests.c:442: error: jump into statement expression
adapttests.c:442: error: jump into statement expression
adapttests.c:443: error: jump into statement expression
adapttests.c:443: error: jump into statement expression
adapttests.c:444: error: jump into statement expression
adapttests.c:444: error: jump into statement expression
adapttests.c:445: error: jump into statement expression
adapttests.c:445: error: jump into statement expression
adapttests.c:446: error: jump into statement expression
adapttests.c:446: error: jump into statement expression
adapttests.c:447: error: jump into statement expression
adapttests.c:447: error: jump into statement expression
adapttests.c:448: error: jump into statement expression
adapttests.c:448: error: jump into statement expression
adapttests.c: In function 'ledtest':
adapttests.c:610: warning: operation on 'led' may be undefined
adapttests.c: In function 'transmittestafsk':
adapttests.c:1103: warning: pointer targets in passing argument 1 of 
'calc_crc_ccitt' differ in signedness
adapttests.c: In function 'saudio':
adapttests.c:1543: warning: unused variable 'phase'
adapttests.c:1538: warning: unused variable 'phdspusb'
adapttests.c:1538: warning: unused variable 'phusbdsp'
make[3]: *** [adapttests.o] Error 1
make[3]: Leaving directory `/tmp/buildd/baycomusb-0.10/diag'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/tmp/buildd/baycomusb-0.10'
make[1]: *** [all-recursive-am] Error 2
make[1]: Leaving directory `/tmp/buildd/baycomusb-0.10'
make: *** [build] Error 2

The attached patch converts the statement expressions to statements,
which fixes the problem.

-- 
Matt

diff -u baycomusb-0.10/diag/adapttests.c baycomusb-0.10/diag/adapttests.c
--- baycomusb-0.10/diag/adapttests.c
+++ baycomusb-0.10/diag/adapttests.c
@@ -398,7 +398,7 @@
   enditer##j:
 
 #define DECODEITERB(j)                                                         
        \
-({                                                                             
        \
+{                                                                              
        \
   flgabrt##j:                                                                  
        \
         if (!(notbitstream & (0x1fc << j))) {              /* abort received 
*/        \
                 state = 0;                                                     
        \
@@ -417,7 +417,7 @@
         numbits--;                                                             
        \
         bitbuf = (bitbuf & ((~0xff) << j)) | ((bitbuf & ~((~0xff) << j)) << 
1);        \
         goto enditer##j;                                                       
        \
-})
+}
         
 /* ---------------------------------------------------------------------- */
 

signature.asc
Description: Digital signature