tag 560469 + patch
thanks
On Fri, Dec 11, 2009 at 09:04:24AM +0100, Lucas Nussbaum wrote:
> Source: galeon
> Version: 2.0.7-1.1
> Severity: serious
> User: [email protected]
> Usertags: qa-ftbfs-20091210 qa-ftbfs
> Justification: FTBFS on amd64
>
> Hi,
>
> During a rebuild of all packages in sid, your package failed to build on
> amd64.
>
> Relevant part:
> > g++ -DHAVE_CONFIG_H -I. -I. -I.. -I../utils -I../utils -I../embed
> > -I../bookmarks -I../libegg -I.. -DXPCOM_GLUE -ldl
> > -I/usr/include/xulrunner-1.9.1/unstable -DXPCOM_GLUE_USE_NSPR
> > -I/usr/include/nspr -I/usr/include/xulrunner-1.9.1/unstable
> > -I/usr/include/xulrunner-1.9.1/unstable/caps
> > -I/usr/include/xulrunner-1.9.1/unstable/chardet
> > -I/usr/include/xulrunner-1.9.1/unstable/chrome
> > -I/usr/include/xulrunner-1.9.1/unstable/content
> > -I/usr/include/xulrunner-1.9.1/unstable/cookie
> > -I/usr/include/xulrunner-1.9.1/unstable/docshell
> > -I/usr/include/xulrunner-1.9.1/unstable/dom
> > -I/usr/include/xulrunner-1.9.1/unstable/exthandler
> > -I/usr/include/xulrunner-1.9.1/unstable/find
> > -I/usr/include/xulrunner-1.9.1/unstable/fastfind
> > -I/usr/include/xulrunner-1.9.1/unstable/gfx
> > -I/usr/include/xulrunner-1.9.1/unstable/helperAppDlg
> > -I/usr/include/xulrunner-1.9.1/unstable/history
> > -I/usr/include/xulrunner-1.9.1/unstable/htmlparser
> > -I/usr/include/xulrunner-1.9.1/unstable/java
> > -I/usr/include/xulrunner-1.9.1/unstable/js -I/usr/include/xulrunner-
> 1.9.1/unstable/jsconsole -I/usr/include/xulrunner-1.9.1/unstable/layout
> -I/usr/include/xulrunner-1.9.1/unstable/locale
> -I/usr/include/xulrunner-1.9.1/unstable/loginmgr
> -I/usr/include/xulrunner-1.9.1/unstable/mimetype
> -I/usr/include/xulrunner-1.9.1/unstable/mozxfer
> -I/usr/include/xulrunner-1.9.1/unstable/necko
> -I/usr/include/xulrunner-1.9.1/unstable/necko2
> -I/usr/include/xulrunner-1.9.1/unstable/nkcache
> -I/usr/include/xulrunner-1.9.1/unstable/nspr
> -I/usr/include/xulrunner-1.9.1/unstable/oji
> -I/usr/include/xulrunner-1.9.1/unstable/passwordmgr
> -I/usr/include/xulrunner-1.9.1/unstable/pipnss
> -I/usr/include/xulrunner-1.9.1/unstable/pipboot
> -I/usr/include/xulrunner-1.9.1/unstable/pref
> -I/usr/include/xulrunner-1.9.1/unstable/progressDlg
> -I/usr/include/xulrunner-1.9.1/unstable/sidebar
> -I/usr/include/xulrunner-1.9.1/unstable/shistory
> -I/usr/include/xulrunner-1.9.1/unstable/string
> -I/usr/include/xulrunner-1.9.1/unstable/uconv
> -I/usr/include/xulrunner-1.9.1/unstable/uriloader
> -I/usr/include/xulrunner-1.9.1/unstable/unic
> harutil -I/usr/include/xulrunner-1.9.1/unstable/wallet
> -I/usr/include/xulrunner-1.9.1/unstable/webbrowserpersist
> -I/usr/include/xulrunner-1.9.1/unstable/webbrwsr
> -I/usr/include/xulrunner-1.9.1/unstable/webshell
> -I/usr/include/xulrunner-1.9.1/unstable/widget
> -I/usr/include/xulrunner-1.9.1/unstable/windowwatcher
> -I/usr/include/xulrunner-1.9.1/unstable/xpcom
> -I/usr/include/xulrunner-1.9.1/unstable/xpconnect
> -I/usr/include/xulrunner-1.9.1/unstable/xulapp -D_REENTRANT -DORBIT2=1
> -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include
> -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0
> -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/directfb
> -I/usr/include/libpng12 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
> -I/usr/include/gtk-unix-print-2.0 -I/usr/include/libxml2
> -I/usr/include/libgnomeui-2.0 -I/usr/include/libart-2.0
> -I/usr/include/gconf/2 -I/usr/include/gnome-keyring-1
> -I/usr/include/libgnome-2.0 -I/usr/include/libbonoboui-2.0
> -I/usr/include/libgnomecanvas-2.0 -I/usr/
> include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include
> -I/usr/include/orbit-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include
> -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0
> -I/usr/include/gail-1.0 -I/usr/include/libglade-2.0
> -I/usr/include/gnome-vfs-module-2.0 -I/usr/include/gnome-desktop-2.0
> -I/usr/include/startup-notification-1.0 -DLIB_DIR=\"/usr/lib/galeon\"
> -DSHARE_DIR=\"/usr/share/galeon\" -D_GNU_SOURCE=1 -include mozilla-config.h
> -fno-rtti -g -O2 -g -Wall -O2 -fshort-wchar -Wall -Wsign-compare
> -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -c ProgressListener.cpp -fPIC
> -DPIC -o .libs/ProgressListener.o
> > In file included from ProgressListener.cpp:23:
> > ProgressListener.h:66: warning: 'GProgressListener' declared with greater
> > visibility than the type of its field 'GProgressListener::<anonymous>'
> > ProgressListener.h:66: warning: 'GProgressListener' declared with greater
> > visibility than its base 'nsSupportsWeakReference'
> > ProgressListener.cpp: In member function 'nsresult
> > GProgressListener::LaunchHelperApp()':
> > ProgressListener.cpp:590: error: invalid conversion from 'const char*' to
> > 'char*'
> > make[4]: *** [ProgressListener.lo] Error 1
The attached patch should fix this.
Mike
--- galeon-2.0.7.orig/mozilla/ProgressListener.cpp
+++ galeon-2.0.7/mozilla/ProgressListener.cpp
@@ -587,12 +587,12 @@
GulCString helperId(helperDesc);
// Format <usertime>:<helperapp id>
- char *colon = strchr (helperId.get(), ':');
+ const char *colon = strchr (helperId.get(), ':');
g_return_val_if_fail (colon, NS_ERROR_FAILURE);
const char *helperappid = colon+1;
- guint32 usertime = strtoul (helperId.get(), &colon, 0);
+ guint32 usertime = strtoul (helperId.get(), NULL, 0);
GnomeVFSMimeApplication *helper =
#ifdef HAVE_NEW_GNOME_VFS_MIME_API
