Hi Guys,
My names Trent and I'm working with the Ubuntu MOTU team.
I recently patched this package to fix this error so it would compile,
so I've attached the patch.
Not sure if this should go upstream of not (given the CVS, etc) - Camm,
could you send upstream if appropriate (if your not sure I'll look into
it harder).
There are other build failures however, I've contacted the maintainer
privately to try sort those out (I sent him this patch too) - it's also
possible that these failures won't affect debian.
Cheers,
Trent
On Tue, Aug 16, 2005 at 01:41:48PM -0700, Matt Kraai wrote:
> Package: gclcvs
> Version: 2.7.0-48
> Severity: serious
>
> gclcvs fails to build because it contains invalid lvalues in some
> assignments:
>
> > gcc -c -Wall -DVOL=volatile -fsigned-char -pipe -O3 -fomit-frame-pointer
> > -I/tmp/buildd/gclcvs-2.7.0/o -I../h -I../gcl-tk format.c
> > format.c: In function 'fmt_case':
> > format.c:1796: error: invalid lvalue in assignment
> > format.c:1802: error: invalid lvalue in assignment
> > format.c:1816: error: invalid lvalue in assignment
> > format.c:1829: error: invalid lvalue in assignment
>
> --
> Matt
--
Trent Lloyd <[EMAIL PROTECTED]>
Bur.st Networking Inc.
diff -Nru /tmp/HQyZgOwdjg/gclcvs-2.7.0/o/format.c
/tmp/ZNwW5ZsUcY/gclcvs-2.7.0/o/format.c
--- /tmp/HQyZgOwdjg/gclcvs-2.7.0/o/format.c 2004-09-17 05:23:28.000000000
+0800
+++ /tmp/ZNwW5ZsUcY/gclcvs-2.7.0/o/format.c 2005-08-26 08:48:46.000000000
+0800
@@ -1793,13 +1793,15 @@
x = x->sm.sm_object0;
if (!colon && !atsign)
for (i = 0; i < x->st.st_fillp; i++) {
- if (isUpper(j = x->st.st_self[i]))
+ j = x->st.st_self[i];
+ if (isUpper(j))
j += 'a' - 'A';
writec_stream(j, fmt_stream);
}
else if (colon && !atsign)
for (b = TRUE, i = 0; i < x->st.st_fillp; i++) {
- if (isLower(j = x->st.st_self[i])) {
+ j = x->st.st_self[i];
+ if (isLower(j)) {
if (b)
j -= 'a' - 'A';
b = FALSE;
@@ -1813,7 +1815,8 @@
}
else if (!colon && atsign)
for (b = TRUE, i = 0; i < x->st.st_fillp; i++) {
- if (isLower(j = x->st.st_self[i])) {
+ j = x->st.st_self[i];
+ if (isLower(j)) {
if (b)
j -= 'a' - 'A';
b = FALSE;
@@ -1826,7 +1829,8 @@
}
else
for (i = 0; i < x->st.st_fillp; i++) {
- if (isLower(j = x->st.st_self[i]))
+ j = x->st.st_self[i];
+ if (isLower(j))
j -= 'a' - 'A';
writec_stream(j, fmt_stream);
}
