>From this error message:
build/src/fw/ssdt-misc.dsl.i      4: DefinitionBlock ("ssdt-misc.aml",
"SSDT", 0x01, "BXPC", "BXSSDTSUSP", 0x1)
Error    6155 -
           Invalid OEM Table ID ^  (Length cannot exceed 8 characters)

Examining the shipped .hex files, I noticed that the TableID string is
truncated to 8 characters only, e.g. in ssdt-misc.hex :

static unsigned char ssdp_misc_aml[] = {
    0x53, 0x53, 0x44, 0x54, 0x62, 0x01, 0x00, 0x00,
    0x01, 0x7f, 0x42, 0x58, 0x50, 0x43, 0x00, 0x00,
    0x42, 0x58, 0x53, 0x53, 0x44, 0x54, 0x53, 0x55,
    0x01, 0x00, 0x00, 0x00, 0x49, 0x4e, 0x54, 0x4c,

Therefore, I assume that the TableID argument can safely be truncated.

This patch fixes the build for me. I confirmed by building on Debian
stable with and without the patch and comparing the .hex files I got
in both cases, they are identical.

diff --git a/src/fw/ssdt-misc.dsl b/src/fw/ssdt-misc.dsl
index acc850e..d1d2c9e 100644
--- a/src/fw/ssdt-misc.dsl
+++ b/src/fw/ssdt-misc.dsl
@@ -1,6 +1,6 @@
 ACPI_EXTRACT_ALL_CODE ssdp_misc_aml

-DefinitionBlock ("ssdt-misc.aml", "SSDT", 0x01, "BXPC", "BXSSDTSUSP", 0x1)
+DefinitionBlock ("ssdt-misc.aml", "SSDT", 0x01, "BXPC", "BXSSDTSU", 0x1)
 {

 /****************************************************************
diff --git a/src/fw/ssdt-pcihp.dsl b/src/fw/ssdt-pcihp.dsl
index cb24c11..518a5eb 100644
--- a/src/fw/ssdt-pcihp.dsl
+++ b/src/fw/ssdt-pcihp.dsl
@@ -1,6 +1,6 @@
 ACPI_EXTRACT_ALL_CODE ssdp_pcihp_aml

-DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1)
+DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPC", 0x1)
 {

 /****************************************************************

On 13 June 2018 at 16:49, Vivia Nikolaidou <n.vi...@gmail.com> wrote:
> Package: seabios
> Version: 1.11.1-1
> Severity: serious
> Justification: Policy 4.15
>
> Dear Maintainer,
>
> SeaBIOS fails to build from source when building on sid and testing.
>
> The error message is:
>
> =================================
>   Compiling IASL src/fw/q35-acpi-dsdt.hex
> build/src/fw/q35-acpi-dsdt.dsl.i    446:     Method(CPEJ, 2, NotSerialized) {
> Remark   2146 -         Method Argument is never used ^  (Arg0)
>
> build/src/fw/q35-acpi-dsdt.dsl.i    446:     Method(CPEJ, 2, NotSerialized) {
> Remark   2146 -         Method Argument is never used ^  (Arg1)
>
> ASL Input:     build/src/fw/q35-acpi-dsdt.dsl.i - 515 lines, 28284 bytes, 413 
> keywords
> AML Output:    build/src/fw/q35-acpi-dsdt.aml - 7506 bytes, 239 named 
> objects, 174 executable opcodes
> Listing File:  build/src/fw/q35-acpi-dsdt.lst - 259530 bytes
> Hex Dump:      build/src/fw/q35-acpi-dsdt.hex - 70865 bytes
>
> Compilation complete. 0 Errors, 0 Warnings, 2 Remarks, 445 Optimizations
>   Compiling IASL src/fw/ssdt-misc.hex
> build/src/fw/ssdt-misc.dsl.i      4: DefinitionBlock ("ssdt-misc.aml", 
> "SSDT", 0x01, "BXPC", "BXSSDTSUSP", 0x1)
> Error    6155 -                                                               
>     Invalid OEM Table ID ^  (Length cannot exceed 8 characters)
>
> ASL Input:     build/src/fw/ssdt-misc.dsl.i - 102 lines, 2567 bytes, 35 
> keywords
> Listing File:  build/src/fw/ssdt-misc.lst - 8417 bytes
> Hex Dump:      build/src/fw/ssdt-misc.hex - 4098 bytes
> =================================
>
> Older SeaBIOS releases are also failing. Workaround is to build the package 
> using a stretch chroot.
>
> -- System Information:
> Debian Release: buster/sid
>   APT prefers unstable-debug
>   APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 
> 'experimental-debug'), (1, 'experimental')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
>
> Kernel: Linux 4.16.0-2-amd64 (SMP w/20 CPU cores)
> Locale: LANG=el_GR.UTF-8, LC_CTYPE=el_GR.UTF-8 (charmap=UTF-8), LANGUAGE= 
> (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> LSM: AppArmor: enabled
>
> -- no debconf information

Reply via email to