Hello,

On Sat, Apr 09, 2016 at 10:26:57PM +0000, Mattia Rizzolo wrote:
> On Sat, Apr 09, 2016 at 02:53:05PM -0700, Sean Whitton wrote:
> >   Description     : Debian helper tool for running ELPA package testsuites
> > 
> > dh-elpa-test will try to run the upstream testsuites for ELPA packages
> > prepared with dh_elpa.  For ELPA packages, dh_auto_test alone is rarely
> > suitable.
> 
> Any reason this can't go in src:dh-elpa itself?

Yeah.  If dh-elpa-test runs the tests for a package, dh_auto_test must
be disabled.  That's because dh_auto_test runs `make test`, and many
ELPA packages will run something that is incompatible with Debian if you
run `make test`.

If dh-elpa-test did not disable dh_auto_test, every package using it
would need boilerplate `override_dh_auto_test: /bin/true`.  But the only
way for a debhelper helper to disable dh_auto_test is in its sequencer
script.  If I put the code to disable dh_auto_test in dh_elpa's sequencer
script (/usr/share/perl5/Debian/Debhelper/Sequence/elpa.pm),
dh_auto_test would be disabled for *all* packages using dh_elpa, which
would be undesirable since some of them have test suites that *can* be
run with a simple `make test`.

So dh-elpa-test needs its own sequencer script in
/usr/share/perl5/Debian/Debhelper/Sequence, and so it also needs its own
corresponding /usr/bin/dh_elpa_test.  But then for ease of maintenance
it should be its own source package.

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature

Reply via email to