tags 133470 - patch confirmed
thanks
ok, the patch supplied by Julian to this bug is bogus since it is
perfectly ok to specify a signcommand != gpg and != pgp,
dpkg-buildpackage will assume a pgp style interface in this case.
On the other the hand, the check that is there really makes no sense
at all since $forcesigninterface can only be pgp or gpg, there is no
other possibility. So it can safely be removed.
The question is wether to introduce another check along the lines
of
--- orig/scripts/dpkg-buildpackage.sh
+++ mod/scripts/dpkg-buildpackage.sh
@@ -120,13 +120,12 @@
if test -n "$forcesigninterface" ; then
signinterface=$forcesigninterface
-if [ "$signinterface" != "gpg" ] && [ "$signinterface" != "pgp" ] ; then
- echo >&2 "$progname: invalid sign interface specified"
- exit 1
-fi
else
signinterface=$signcommand
fi
+if [ -n "$signcommand" ] && [ "$signinterface" != "gpg" ] && [
"$signinterface" != "pgp" ] ; then
+ echo >&2 "$progname: unknown sign interface specified, assuming pgp"
+fi
mustsetvar () {
If that is not wanted this bug can safely be closed (with or without
removing the superfluous check...)
Gruesse,
--
Frank Lichtenheld <[EMAIL PROTECTED]>
www: http://www.djpig.de/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
