Re: First patch attempt for PATH_MAX fix in ruby1.9.1- 1.9.3~rc1-3

[Pino Toscano]

Hi,

Alle giovedì 13 ottobre 2011, Svante Signell ha scritto:
> Below is a patch attempt to solve the PATH_MAX issue on the latest
> ruby1.9.1.

I don't think this is correct: various functions in addr2line.c seem to 
assume the buffer is always the same, and they call themselves 
recursively (e.g. rb_dump_backtrace_with_lines (sets binary_filename) -> 
fill_lines -> follow_debuglink (sets binary_filename) -> fill_lines -> 
...). With your patch, it would also cause the binary_filename pointer 
to be stale over runs.

-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.