I'm not a DD so I can't upload this, but I took a look. I see you've
addressed most of the comments on Mentors in the repository on GitHub,
so I'm reviewing that rather than the older upload on Mentors.
Build-Depends lists pkg-config, which is a transitional package since
bookworm that should be replaced with the newer pkgconf. lintian warns
about this:
W: rgbds source: build-depends-on-obsolete-package Build-Depends:
pkg-config => pkgconf
This is just a suggestion/tip and not at all required, but it's popular
to use `wrap-and-sort -ast` to put each dependency on its own line (with
a trailing comma). This would make the diff clearer in commits like
d1842536 and 22baba8b.
The years in the Copyright field of the "Files: *" stanza of d/copyright
look outdated: "1997-2020" when LICENSE says "1997-2023" since commit
f8af5696.
Not required by all sponsors, but Emmanuel on Mentors and Tobias here
suggested maintaining the packaging Git repository on Salsa (and
updating the Vcs- fields):
https://salsa.debian.org/
https://salsa.debian.org/games-team
https://salsa.debian.org/debian
You may also want to look into git-buildpackage with pristine-tar and a
DEP-14 branch layout:
https://honk.sigxcpu.org/piki/projects/git-buildpackage/
https://www.eyrie.org/~eagle/notes/debian/git.html
https://dep-team.pages.debian.net/deps/dep14/
Looks OK otherwise to me, and the package builds fine under sbuild with
no lintian tags (even informational or pedantic) other than the obsolete
package warning above; nice work! So, once the pkg-config -> pkgconf
switch and copyright years update are done, I think it's good enough for
someone to upload.
--
Patrick "P. J." McDermott: http://www.pehjota.net/
Lead Developer, ProteanOS: http://www.proteanos.com/
Founder and CEO, Libiquity: http://www.libiquity.com/
