Hi,

May I also suggest renaming this 'upload_history.distribution' column
to 'upload_history.release' for a better consistency with the other
tables that have the two columns (distribution and release)?

More generally there are some other places in the UDD source code
where it is confusing, for instances here (extract using rgrep):

web/cgi-bin/arch.cgi:#$query = "select
architecture,distribution,state,count(*) from wannabuild where
distribution ='sid' and state='Installed' group by
architecture,distribution,state order by count;";
web/cgi-bin/arch.cgi:        $arch_info->{$arch}->{"longest_build"} =
$rowsc->{"package"}."/".$rowsc->{"distribution"};
web/cgi-bin/arch.cgi:
$arch_info->{$arch}->{"longest_needsbuild"} =
$rowsc->{"package"}."/".$rowsc->{"distribution"};

Here it is with the 'wannabuild' table.

web/cgi-bin/mentors.cgi:pkgs = dbget("select mp.name, mpv.version,
mpv.distribution, pc.insts, mpv.uploaded
web/cgi-bin/mentors.cgi:<th>bug</th><th>source</th><th>version</th><th>distribution</th><th>uploaded</th><th>&nbsp;&nbsp;&nbsp;popcon&nbsp;&nbsp;&nbsp;</th><th>in
Debian</th><th>status</th><th>links</th>
web/cgi-bin/mentors.cgi:    if l['distribution'] == 'unstable'
web/cgi-bin/mentors.cgi:    elsif l['distribution'] == 'experimental'
web/cgi-bin/mentors.cgi:  puts "<td>#{l['distribution']}</td>"

And here it is the 'mentors_most_recent_package_versions' view based
on the 'mentors_raw_uploads' table.

Could this be improved or too late?
How? (some SQL ALTER with cgi patches?)

Regards,
Patrice

Le mer. 14 févr. 2024 à 19:36, Patrice Duroux
<patrice.dur...@gmail.com> a écrit :
>
> Hi,
>
> I am a bit surprised with the following output:
>
> udd=> select distinct distribution from upload_history;
>           distribution
> ---------------------------------
>  experimental
>  froxzen unstable
>  froze unstable
>  frozen
>  frozen  unstable
>  frozen unstable
>  frozen unstable contrib
>  frozen woody
>  frozen-contrib contrib
>  non-free
>  rc-buggy
>  sid
>  sid=20
>  stable
>  stable frozen unstable
>  stable unstable
>  stable-security
>  testing
>  testing unstable
>  testing-security
>  unstable
>  unstable  frozen
>  unstable contrib
>  unstable frozen
>  unstable non-free
>  unstable stable
>  unstable stable frozen
>  unstable testing
>  unstable testing stable
>  unstable unstable
>  unstable=20
>  woody-proposed-updates unstable
> (32 lignes)
>
>
> I am then not sure about the consistency of another SQL query based on
> this column value.
>
> Regards,
> Patrice

Reply via email to