Hi,
Chris Frey wrote (08 May 2012 06:01:58 GMT) :
> I believe this release can be uploaded.
Almost :)
Next review round results in:
1. debian/copyright may be syntaxically correct, but it looks weird
compared to how people usually put things in there.
Attached patch fixes this. Please consider applying it.
2. I don't think "src/vformat.{h,c}" is supported syntax in a Files:
field in debian/copyright.
3. The homepage set in debian/control is not the same as the one set
in debian/copyright. This looks wrong.
4. barrydesktop Suggests: gksu. How usable is it without gksu?
5. It seems to me BARRY_FIFO_NAME is handled in a way that opens
avenues to symlink attacks. Am I wrong? Files in world-writable
directories must be treated with care.
>From b6312d33c873f1e1c0ec9d151f120c84abe92500 Mon Sep 17 00:00:00 2001
From: intrigeri <intrig...@boum.org>
Date: Fri, 11 May 2012 09:56:33 +0200
Subject: [PATCH] Reformat debian/copyright to suit informal style habits.
---
debian/copyright | 76 ++++++++++++++++++++----------------------------------
1 file changed, 28 insertions(+), 48 deletions(-)
diff --git a/debian/copyright b/debian/copyright
index eefae85..69340fe 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -2,62 +2,42 @@ Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: Barry
Upstream-Contact: Chris Frey <cdf...@foursquare.net>
Source: http://sourceforge.net/projects/barry
-License: GPL-2+
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License as published by
- the Free Software Foundation; either version 2 of the License, or
- (at your option) any later version.
- .
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
- .
- You should have received a copy of the GNU General Public License along
- with this program; if not, write to the Free Software Foundation, Inc.,
- 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
- .
- On Debian systems, the complete text of the GNU General
- Public License can be found in `/usr/share/common-licenses/GPL-2'.
Files: *
+Copyright: © 2005-2012 Net Direct Inc. (http://www.netdirect.ca/)
+Copyright: © 2007-2012 Chris Frey <cdf...@foursquare.net>
+Copyright: © 2008 Brian Edginton (e...@edginton.net)
+Copyright: © 1995-1999 Cryptography Research, Inc.
+Copyright: © 2003 Ximian, Inc. 2005 Armin Bauer
+Copyright: © 2008-2012 Nicolas VIVIEN <nico...@vivien.fr>
+Copyright: © 2009 Josh Kropf <j...@slashdev.ca>
+Copyright: © 2010-2012 RealVNC Ltd., Toby Gray
License: GPL-2+
- See global license section for details
-Copyright:
- Copyright (C) 2005-2012, Net Direct Inc. (http://www.netdirect.ca/)
- Copyright (C) 2007-2012, Chris Frey <cdf...@foursquare.net>
- Copyright (C) 2008, Brian Edginton (e...@edginton.net)
- Copyright (C) 1995-9 by Cryptography Research, Inc.
- Copyright (C) 2003 Ximian, Inc. 2005 Armin Bauer
- Copyright (C) 2008-2012, Nicolas VIVIEN <nico...@vivien.fr>
- Copyright (C) 2009, Josh Kropf <j...@slashdev.ca>
- Copyright (C) 2010-2012, RealVNC Ltd., Toby Gray
Files: contrib/*
+Copyright: © 2008 Niels de Vos <nixpa...@users.sourceforge.net>
+Copyright: © 2008 ashley willis <ba...@venamous.net>
License: GPL-2+
- See global license section for details
-Copyright:
- Copyright (C) 2008 Niels de Vos <nixpa...@users.sourceforge.net>
- Copyright (C) 2008, ashley willis <ba...@venamous.net>
Files: src/vformat.{h,c}:
+Copyright: © 2003 Ximian, Inc.
+Copyright: © 2005 Armin Bauer
License: LGPL
- This library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Lesser General Public
- License as published by the Free Software Foundation; either
- version 2.1 of the License, or (at your option) any later version.
- .
- This library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Lesser General Public License for more details.
- .
- You should have received a copy of the GNU Lesser General Public
- License along with this library; if not, write to the Free Software
- Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+
+License: GPL-2+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 2 of the License, or
+ (at your option) any later version.
.
- On Debian systems, the complete text of the GNU Lesser General
- Public License can be found in `/usr/share/common-licenses/LGPL-2.1'.
-Copyright:
- Copyright (C) 2003 Ximian, Inc.
- Copyright (C) 2005 Armin Bauer
+ On Debian systems, the complete text of the GNU General
+ Public License can be found in `/usr/share/common-licenses/GPL-2'.
+License: LGPL
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+ .
+ On Debian systems, the complete text of the GNU Lesser General
+ Public License can be found in `/usr/share/common-licenses/LGPL-2.1'.
--
1.7.10
