Your message dated Tue, 01 Aug 2023 09:49:35 +0000
with message-id <e1qqm0v-00hmr6...@fasolo.debian.org>
and subject line Bug#1034413: fixed in xorg-server 2:21.1.8-1
has caused the Debian Bug report #1034413,
regarding xorg-server: present-Check-for-NULL-to-prevent-crash.patch not needed 
anymore
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1034413: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1034413
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: xorg-server
Version: 2:21.1.7-2
Severity: minor
Tags: patch

Dear Maintainer,

I've been testing the xorg-server debian package for bookworm. I realized
that although patch "present-Check-for-NULL-to-prevent-crash.patch" applies
after some Hunk fixes, the result is incorrect because the patch
is already available upstream.

chema@bookworm:~/package/xorg-server-debian/xorg-server-21.1.7/debian$ quilt
push
Applying patch present-Check-for-NULL-to-prevent-crash.patch
patching file present/present_scmd.c
Hunk #1 succeeded at 161 with fuzz 1 (offset 3 lines).
Hunk #2 succeeded at 205 with fuzz 1 (offset 6 lines).

Now at patch present-Check-for-NULL-to-prevent-crash.patch

So I recommend to remove this patch for bookworm and newer versions
of the xserver 21.1.7 already includes the path and is available on
21.1 branch since 21.1.4

The result at the final debian source does not harm but it is not
really nice as it is repeating the same validation:

static RRCrtcPtr
present_scmd_get_crtc(present_screen_priv_ptr screen_priv, WindowPtr window)
{
if (!screen_priv->info)
return NULL;

if (!screen_priv->info->get_crtc)
return NULL;

> if (!screen_priv->info->get_crtc)
> return NULL;

return (*screen_priv->info->get_crtc)(window);
}

------

static void
present_flush(WindowPtr window)
{
ScreenPtr screen = window->drawable.pScreen;
present_screen_priv_ptr screen_priv = present_screen_priv(screen);

if (!screen_priv)
return;

if (!screen_priv->info)
return;

> if (!screen_priv->info->flush)
> return;

if (!screen_priv->info->flush)
return;

(*screen_priv->info->flush) (window);
}

-- System Information:
Debian Release: 11.6
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500,
'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.0-21-amd64 (SMP w/12 CPU threads)
Locale: LANG=es_ES.UTF-8, LC_CTYPE=es_ES.UTF-8 (charmap=UTF-8), LANGUAGE not
set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

--- End Message ---
--- Begin Message ---
Source: xorg-server
Source-Version: 2:21.1.8-1
Done: Timo Aaltonen <tjaal...@debian.org>

We believe that the bug you reported is fixed in the latest version of
xorg-server, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1034...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Timo Aaltonen <tjaal...@debian.org> (supplier of updated xorg-server package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 01 Aug 2023 12:26:02 +0300
Source: xorg-server
Built-For-Profiles: noudeb
Architecture: source
Version: 2:21.1.8-1
Distribution: unstable
Urgency: medium
Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
Changed-By: Timo Aaltonen <tjaal...@debian.org>
Closes: 1034413
Changes:
 xorg-server (2:21.1.8-1) unstable; urgency=medium
 .
   * patches: Drop an obsolete patch. (Closes: #1034413)
   * New upstream release.
Checksums-Sha1:
 fb803918d3489c86930044ee077ede66afe85c9a 4207 xorg-server_21.1.8-1.dsc
 8aec9bb6c2e7406e09c7be984c0499104ad2f95c 8981767 xorg-server_21.1.8.orig.tar.gz
 0e488764b318a599305dd506a9e4bc2759ec3f02 195 xorg-server_21.1.8.orig.tar.gz.asc
 ba2277f8153fe8d80051058c41c9e7539cc14118 168045 xorg-server_21.1.8-1.diff.gz
 ceb478e89454b0f2efd8a6bfe2ccaafd06876c33 10428 
xorg-server_21.1.8-1_source.buildinfo
Checksums-Sha256:
 db28b2c1131062d9115c0eab4703e68909e80d736eb762190bb6784829377ff2 4207 
xorg-server_21.1.8-1.dsc
 d845d1fee2edb33cb94f31b5170f26d98ed31f853ce2da21daca7c60c8ff3aae 8981767 
xorg-server_21.1.8.orig.tar.gz
 112365fa0c57dce55424a7b3e4cc565ba738b27be4f795f0fbc62df7dd1e1094 195 
xorg-server_21.1.8.orig.tar.gz.asc
 4903cb6166d4ed470a9e242dbd77caf55ff709ac123b79898bc6a1082c4e84ff 168045 
xorg-server_21.1.8-1.diff.gz
 491793633ae390a42b98c6566a31c98d666918877d5f5397a10c82c28dffac53 10428 
xorg-server_21.1.8-1_source.buildinfo
Files:
 aa5f4dfbf8abceff9765125d07c000d9 4207 x11 optional xorg-server_21.1.8-1.dsc
 899ebd83dabaf081511b69280a9a8e3d 8981767 x11 optional 
xorg-server_21.1.8.orig.tar.gz
 d5ade7b3c26ffbb6c0390138423eb0a5 195 x11 optional 
xorg-server_21.1.8.orig.tar.gz.asc
 59f1f7f107655615f0c99dde894e6a24 168045 x11 optional 
xorg-server_21.1.8-1.diff.gz
 a49593bb0b22434e933f38b05f11e9d0 10428 x11 optional 
xorg-server_21.1.8-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdS3ifE3rFwGbS2Yjy3AxZaiJhNwFAmTIz8UACgkQy3AxZaiJ
hNx0gA/8C2SSxEFCK0+axWLOwRx6GIkSW3Dnd02XX9hmDVcrohdrubYFGWti3eD6
b6IZnvA/j07DCf5yV3Z8WQyNBIyCqKatvlNcldwv+xCuLO+qWjjMpflYNnQYPAxE
gMtTMcO4VBDsYr7RgA6R1mYMh4pLH0t83WCkqZRMLytQqDe/JqdysZe1MfbxO58s
hkLeGW2c/lE33n8QS9Q7hYi0Kc3lwCsAQtGlNab15xN+LzKAmN0/dk6crtAEV4D1
w/TtAEk8QKxqzfTMoROV7BstYgkco1gm9jYGMqPb4Bn17eQ0f0+19kP65d3X3A/1
0ZJh7qvGlfTOqaxIjm6fSBqvbYM83Z8s48KWL8My+tLwmdpGLoXe4Z54kntPJIID
N+6hepkk5ILzWUHFOleElOlfV6llrBvzNilrOUNvJYfdlKZTtWerm2nTe3ftXILP
rb0p8ZXTMW4wgL1s607+PzXdbhyJ4tXW7iQxLLk0AphsXHtIJbUPdjDoeAwau5Fj
T5S3FvrvqDI3Wwkn4ga+W1mmK2RgU8sAoN3bpnRaOao8ZISVFYK8mlYmZbjLevxq
MeZ8nhqm4sHem3YUf5uia0BSXY8+RDHGGL+uuneDLzDk19gwdssS2oTU2XTj4dlE
UimC7Fn568ZadHXWZSRF33eljRiy3y6KKDdVtZHT/Lcx885Tcs8=
=OdQL
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to