Timo Aaltonen pushed to branch upstream-experimental at X Strike Force / lib / mesa
Commits: ba5fd74a by Thong Thai at 2024-01-29T17:31:50+00:00 radeonsi/vcn: remove EFC support for renoir Renoir hardware has limited EFC support, so remove support for it from Mesa. Thanks to @nyanmisaka for raising the issue. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9436 Signed-off-by: Thong Thai <thong.t...@amd.com> Reviewed-by: Ruijing Dong <ruijing.d...@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27076> (cherry picked from commit df5203d6316d8b79705c6fa37fecb0d072a63caa) - - - - - 77c2a5d4 by Eric Engestrom at 2024-01-29T18:09:22+00:00 .pick_status.json: Update to b75ee1a0670a3207dfd99917e4f47d064a44197f - - - - - 7e4e5fbd by Mike Blumenkrantz at 2024-01-29T21:06:57+00:00 zink: set more dynamic states when using shader objects fixes #10457 cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27146> (cherry picked from commit df45cbddb59a19293dc63f2d7df0d2fbc24a457e) - - - - - aba20a93 by Rhys Perry at 2024-01-29T21:07:00+00:00 aco: fix labelling of s_not with constant Fixes RADV compilation of a Cyberpunk 2077 RT pipeline with PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT. Signed-off-by: Rhys Perry <pendingchao...@gmail.com> Fixes: dfaa3c0af69a ("aco: Flip s_cbranch / s_cselect to optimize out an s_not if possible.") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27194> (cherry picked from commit 6dc182b6b21520bfa68b647cae9fb303e286980a) - - - - - 09bace40 by Faith Ekstrand at 2024-01-29T21:07:01+00:00 nvk: Don't exnore ExternalImageFormatInfo Fixes: 702326d0138f ("nvk: Add external memory queries") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27242> (cherry picked from commit 58e916b3b7e0328e43d914f8a3d6d0906210ac97) - - - - - 2588d3f4 by Dave Airlie at 2024-01-29T21:07:02+00:00 gallivm: passing fp16_split_fp64 to fp16 lowering. This causes lavapipe to use the split code and fixes accuracy for CTS. Fixes dEQP-VK.glsl.builtin.precision_fconvert.f64_to_f16* Cc: mesa-stable Reviewed-by: Mike Blumenkrantz <michael.blumenkra...@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27228> (cherry picked from commit 38e92556a041cc421dadb95aaac43a4619311a87) - - - - - 77e4a2a0 by Rohan Garg at 2024-01-29T21:10:02+00:00 anv: untyped data port flush required when a pipeline sets the VK_ACCESS_2_SHADER_STORAGE_READ_BIT VK_ACCESS_2_SHADER_STORAGE_READ_BIT specifies read access to a storage buffer, physical storage buffer, storage texel buffer, or storage image in any shader pipeline stage. Any storage buffers or images written to must be invalidated and flushed before the shader can access them. This fixes the following tests on LNL: - dEQP-VK.synchronization2.op.single_queue.barrier.write\*_specialized_access_flag Signed-off-by: Rohan Garg <rohan.g...@intel.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27212> (cherry picked from commit 3e93ccbc1b25d3e24f1672eaf1fbdb998ca94173) - - - - - 5b7553a1 by Dmitry Baryshkov at 2024-01-29T21:16:20+00:00 freedreno/drm: don't crash for unsupported devices For unsupported devices fd_pipe_new() will return NULL, causing a crash when fd_device_new() tries to check device generation. Handle fd_pipe_new() returning NULL by destroying device and returning NULL. Fixes: 48610676897d ("freedreno/drm: Add sub-allocator") Signed-off-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26961> (cherry picked from commit 7a81855a67526809d1ff2e3a70c7991e52948e3e) - - - - - 8f9db1db by Lionel Landwerlin at 2024-01-29T21:16:33+00:00 anv: don't prevent L1 untyped cache flush in 3D mode Required on MTL. Fixes tests like : dEQP-VK.synchronization2.op.single_queue.timeline_semaphore.write_copy_buffer_read_copy_buffer.buffer_16384 Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Cc: mesa-stable Co-Authored-by: Jordan Justen <jordan.l.jus...@intel.com> Tested-by: Matt Turner <matts...@gmail.com> Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27172> (cherry picked from commit 7c2ff46a4fc3e537573ac9503057e0cd29b6fff3) - - - - - 6ffceb71 by Faith Ekstrand at 2024-01-29T21:16:35+00:00 nak: Fix TCS output reads The hardware uses the lane index for per-vertex TCS output reads rather than the vertex index. Fortunately, it's a pretty easy calculation to go from one to the other. Fixes: abe9c1fea2d7 ("nak: Add NIR lowering for attribute I/O") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27284> (cherry picked from commit 99ef70d8aafb22f3ffac21aa0414ae95afcee5ea) - - - - - dc7b4111 by Louis-Francis Ratté-Boulianne at 2024-01-29T22:06:19+00:00 panfrost: factor out method to check whether we can discard resource The logic is gonna be re-used to determine whether we need to unpack a AFBC-packed texture before updating it (when unmapping). Signed-off-by: Louis-Francis Ratté-Boulianne <l...@collabora.com> Reviewed-by: Erik Faye-Lund <erik.faye-l...@collabora.com> Fixes: 33b48a55857 ("panfrost: Add debug flag to force packing of AFBC textures on upload") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27208> (cherry picked from commit 22a7637b08255acc998e67bbdbc1ed34daf21465) - - - - - dae3eb15 by Louis-Francis Ratté-Boulianne at 2024-01-29T22:07:29+00:00 panfrost: add copy_resource flag to pan_resource_modifier_convert When converting the modifier for a resource, it's not always needed to blit the content as well. Creating a new resource with the right format/modifier might be enough. Signed-off-by: Louis-Francis Ratté-Boulianne <l...@collabora.com> Reviewed-by: Erik Faye-Lund <erik.faye-l...@collabora.com> Fixes: 33b48a55857 ("panfrost: Add debug flag to force packing of AFBC textures on upload") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27208> (cherry picked from commit 62ed14b3868e304371b3e096da94c6dc3e24a299) - - - - - 97c0e12d by Louis-Francis Ratté-Boulianne at 2024-01-29T22:07:30+00:00 panfrost: add can_discard flag to pan_legalize_afbc_format There might be a more efficient path when legalizing a resource if we don't need to worry about its content. For example, it doesn't make sense to copy the resource content when converting the modifier if the resource content is discarded anyway. Signed-off-by: Louis-Francis Ratté-Boulianne <l...@collabora.com> Reviewed-by: Erik Faye-Lund <erik.faye-l...@collabora.com> Fixes: 33b48a55857 ("panfrost: Add debug flag to force packing of AFBC textures on upload") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27208> (cherry picked from commit ee77168d575cd41c0202ef918bf4935cc1603489) - - - - - e7715e39 by Louis-Francis Ratté-Boulianne at 2024-01-29T22:07:32+00:00 panfrost: Legalize before updating part of a AFBC-packed texture When updating an AFBC-packed resource, we need to make sure it is legalized before blitting the staging resource to it. We can't rely on the blit to properly convert the resource as it will result in blit recursion and a crash. If the whole texture is updated however, there is no need to unpack as the content can be discarded. Just create a new BO with the right format. Signed-off-by: Louis-Francis Ratté-Boulianne <l...@collabora.com> Reviewed-by: Erik Faye-Lund <erik.faye-l...@collabora.com> Fixes: 33b48a55857 ("panfrost: Add debug flag to force packing of AFBC textures on upload") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27208> (cherry picked from commit 1aa832e5f5879e70a2c25c3517951ccddd36a599) - - - - - 439aff7f by Lionel Landwerlin at 2024-01-29T22:07:52+00:00 anv: add missing alignment for AUX-TT mapping Buffers that are not dedicated can also be used for CCS mapped images, so they need to be aligned to the AUX-TT requirements. GTK+ is running into such case where it creates an image with a CCS modifier. When requesting the alignment through vkGetImageMemoryRequirements() the 64KB/1MB alignment is returned, but the binding fails with an assert because the VkDeviceMemory has not been aligned to the AUX-TT requirement and we cannot disable CCS since the modifier requires it. Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Fixes: 4cdd3178fb ("anv: Meet CCS alignment reqs with dedicated allocs") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10433 Reviewed-by: Jianxun Zhang <jianxun.zh...@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27258> (cherry picked from commit e519e06f4b274fabf9302626c6e63d084372c1ea) - - - - - 88880bfc by Pierre-Eric Pelloux-Prayer at 2024-01-29T22:07:53+00:00 radeonsi: emit cache flushes before draw registers This fixes #9807 but I don't understand why. Emitting cache flushes before VGT_PRIMITIVE_TYPE is what makes the problem go away but changing the order in si_draw() is clearer. The only cases where sctx->flags is modified in si_emit_draw_registers is handled using si_emit_cache_flush_direct so we can move cache flushing up without any addtional conditionals. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9807 Fixes: 1e4b5390425 ("radeonsi: handle deferred cache flushes as a state (si_atom)") Reviewed-by: Marek Olšák <marek.ol...@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27095> (cherry picked from commit 0e16da89fefb8ec38fafbd26ca4a60fc3c1e3b4c) - - - - - 68e58263 by Pierre-Eric Pelloux-Prayer at 2024-01-29T22:07:53+00:00 radeonsi: adjust flags for si_compute_shorten_ubyte_buffer - no need to flush anything before as we're working on a clean buffer (SI_OP_SKIP_CACHE_INV_BEFORE) - L2 must be flushed after the job to avoid rendering artifacts. Instead of setting it manually, use SI_OP_SYNC_AFTER + SI_COHERENCY_NONE. Fixes: 1a99f50c7f2 ("radeonsi: use a compute shader to convert unsupported indices format") Reviewed-by: Marek Olšák <marek.ol...@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27095> (cherry picked from commit cce59200254fe6b0d45f408777e9cf3490359d24) - - - - - 66d3b00e by Lionel Landwerlin at 2024-01-29T22:22:15+00:00 anv: factor out aux-tt binding logic for future reuse Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Reviewed-by: Jianxun Zhang <jianxun.zh...@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27304> (cherry picked from commit fdc2f0a52e5225a8fbe41fde1329e18b7a99d6f4) - - - - - 8be6eab8 by Lionel Landwerlin at 2024-01-29T22:22:25+00:00 anv: rename aux_tt image field We'll add more to the sub-struct Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Reviewed-by: Jianxun Zhang <jianxun.zh...@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27304> (cherry picked from commit eead86ad8e353234f47e00fb25b393dddb15106c) - - - - - 5f792162 by Lionel Landwerlin at 2024-01-29T22:22:31+00:00 anv: retain ccs image binding address Memory can be free before images it is bound to. When unmapping the CCS range in the AUX-TT, we cannot rely on the anv_bo::offset field because the anv_bo might have been freed. Just save the mapping address/size and use those values at unmapping time. Fixes an assert on CI with : dEQP-VK.synchronization.internally_synchronized_objects.pipeline_cache_graphics Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Fixes: e519e06f4b ("anv: add missing alignment for AUX-TT mapping") Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27304> (cherry picked from commit 9d31680e79ad1aa3a91e917a9e3d615453203298) - - - - - 4c62d392 by Sebastian Wick at 2024-01-31T19:31:13+00:00 radeonsi: Destroy queues before the aux contexts Otherwise the queue might access the already destroyed aux contexts Signed-off-by: Sebastian Wick <sebastian.w...@redhat.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com> Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-pra...@amd.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27300> (cherry picked from commit c467a87e06e21ad9e8bcc9e3556b6fc6f19a1bf1) - - - - - a3153531 by Gert Wollny at 2024-01-31T19:31:13+00:00 r600: lower dround_even also on hardware that supports fp64 Fixes: aed6a39c10c328c32e6009e6f5c00cfdd9257e73 glsl: Retire dround lowering. Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27329> (cherry picked from commit 820859a6abd7e6186070f3d51491bba4a1456618) - - - - - 570faac1 by Samuel Pitoiset at 2024-01-31T19:31:13+00:00 radv: fix segfault when getting device vm fault info pFaultInfo can be NULL. Fixes: 8097becc7f1 ("radv: add initial VK_EXT_device_fault support") Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27292> (cherry picked from commit c68f96878ce208f2c1cbd32aa143c8cbf68b3a36) - - - - - ea8681f9 by Gert Wollny at 2024-01-31T19:31:13+00:00 virgl: Use better reporting for mirror_clamp features Fixes: 9efe50c83bfa3678fe7ad3cfcd94cf73d900be22 virgl: report MIRROR_CLAMP features better Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27106> (cherry picked from commit b9fea5ea6b5e5c79c916792cdb45a2a9ca0f522e) - - - - - 6cced860 by Tapani Pälli at 2024-01-31T19:32:15+00:00 anv: move *bits_for_access_flags to genX_cmd_buffer This makes is possible to use GFX_VER macros in these functions. Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> (cherry picked from commit d0a3bac163ca803eda03feb3afea80e516568caf) Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27354> - - - - - e6990f03 by Lionel Landwerlin at 2024-01-31T19:32:15+00:00 anv: fix transfer barriers flushes with compute queue Transfer operation are implemented differently on the compute engine and require a different kind of cache flush. Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Cc: mesa-stable Reviewed-by: Sagar Ghuge <sagar.gh...@intel.com> (cherry picked from commit 3b9466dd517feede421c0978893649eb1f46e8ab) Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27354> - - - - - ce8c9596 by Eric Engestrom at 2024-01-31T21:21:49+00:00 .pick_status.json: Update to 4cd5b2b5426e8d670fc3657eee040a79e3f9df1e - - - - - d1b2c415 by Eric Engestrom at 2024-01-31T21:22:03+00:00 util: rename __check_suid() to __normal_user() Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27346> (cherry picked from commit 3e00558ef00d76a32843fc08eae8d1ba22428ad5) - - - - - 26db7041 by Eric Engestrom at 2024-01-31T21:22:04+00:00 tree-wide: use __normal_user() everywhere instead of writing the check manually Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27346> (cherry picked from commit 92c24191d4ee9379626c5fef9f6c234f64eeeee1) - - - - - 780b69eb by Eric Engestrom at 2024-01-31T21:22:08+00:00 util: simplify logic in __normal_user() Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27378> (cherry picked from commit afd4e633eecb03a548b06db73a5d70067413a4c2) - - - - - 6924679f by Eric Engestrom at 2024-01-31T21:22:09+00:00 util: check for setgid() as well in __normal_user() Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27378> (cherry picked from commit 501f78fdbae91c889c1c472265ab930c3e36b9bd) - - - - - ec4d013e by Friedrich Vock at 2024-01-31T22:21:23+00:00 util: Provide a secure_getenv fallback for platforms without it Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27381> (cherry picked from commit 8b209a62006ad6fd4593bb4f528ce8aee23fc038) - - - - - 1aab9bc3 by Friedrich Vock at 2024-01-31T22:21:23+00:00 vulkan: Use secure_getenv for trigger files Reviewed-by: Eric Engestrom <e...@igalia.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27381> (cherry picked from commit 7ea96ff75b771ea8eb48d2b9fec05e5edc958b21) - - - - - bbe9e29f by Friedrich Vock at 2024-01-31T22:21:23+00:00 aux/trace: Guard triggers behind __normal_user Reviewed-by: Eric Engestrom <e...@igalia.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27381> (cherry picked from commit f3b892b74ab7db998dd24d8443803ba9dc20f8a6) - - - - - cad34747 by Friedrich Vock at 2024-01-31T22:21:23+00:00 vtn: Use secure_getenv for shader dumping Reviewed-by: Eric Engestrom <e...@igalia.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27381> (cherry picked from commit 321e2cee5315e94c050f8659a8cd55e0e7cd9076) - - - - - 6bcf386f by Friedrich Vock at 2024-01-31T22:21:23+00:00 mesa/main: Use secure_getenv for shader dumping Reviewed-by: Eric Engestrom <e...@igalia.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27381> (cherry picked from commit 72f95a8364c018ed833aab171f8d5fa65145cb10) - - - - - 566c2835 by Friedrich Vock at 2024-01-31T22:21:23+00:00 radv: Use secure_getenv in radv_builtin_cache_path Reviewed-by: Eric Engestrom <e...@igalia.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27381> (cherry picked from commit c01a07f2e47bc778ff6faf665b98be5556c77e77) - - - - - 9ac7a658 by Friedrich Vock at 2024-01-31T22:21:23+00:00 radv: Use secure_getenv for RADV_THREAD_TRACE_TRIGGER Reviewed-by: Eric Engestrom <e...@igalia.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27381> (cherry picked from commit e8b0e5cac9062f9f290a46460279eaa3eb0c60a8) - - - - - e5ef4678 by Friedrich Vock at 2024-01-31T22:21:23+00:00 util/disk_cache: Use secure_getenv to determine cache directories Reviewed-by: Eric Engestrom <e...@igalia.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27381> (cherry picked from commit 1c01fd028616c755fdac59016b17b07933a416ed) - - - - - d2064c52 by Haihao Xiang at 2024-01-31T22:21:23+00:00 anv: Fix typo in transition_color_buffer Signed-off-by: Haihao Xiang <haihao.xi...@intel.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27330> (cherry picked from commit 29d18f3ca90ba16ea02b0b3b93d5b07dfd6d9f2b) - - - - - f135adb8 by Leo Liu at 2024-01-31T22:21:23+00:00 radeonsi: fix video processing path without VPE enabled Fixes: 6b441ef6ab1e89d (amd, radeonsi: supports post processing entrypoint) Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10495 Cc: mesa-stable Signed-off-by: Leo Liu <leo....@amd.com> Reviewed-by: Ruijing Dong <ruijing.d...@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27339> (cherry picked from commit 46f5a226d6613e0a4c7b3a3496e745090fc14429) - - - - - 22a21925 by Gert Wollny at 2024-01-31T22:21:23+00:00 radv: Fix compilation with gcc-13 and tsan enabled ../src/amd/vulkan/radv_sampler.c: In function ‘radv_tex_wrap’: ../src/amd/vulkan/radv_sampler.c:50:1: error: control reaches end of non-void function [-Werror=return-type] 50 | } | ^ ../src/amd/vulkan/radv_sampler.c: In function ‘radv_tex_compare’: ../src/amd/vulkan/radv_sampler.c:76:1: error: control reaches end of non-void function [-Werror=return-type] 76 | } | ^ Fixes: 4de305cb8a3c68df8e89f8c1359f510a1089cfd3 radv: move sampler related code to radv_sampler.c Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27345> (cherry picked from commit ca47138fb17c87d49347e4ec00cedbb656afe747) - - - - - cb7fe98f by Gert Wollny at 2024-01-31T22:21:23+00:00 nir/lower_int64: Fix compilation with gcc-13 and tsan enabled ../src/compiler/nir/nir_lower_int64.c: In function ‘lower_int64_intrinsic’: ../src/compiler/nir/nir_lower_int64.c:1347:1: error: control reaches end of non-void function [-Werror=return-type] 1347 | } Fixes: bf7a11424650af2ac9e8f546741fb6ab2ed3b8d7 nir/lower_int64: Add lowering for some 64-bit subgroup ops Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27345> (cherry picked from commit 80a1b91601172be9c13d5f3ef63f126ecdaa1c15) - - - - - b728809a by Gert Wollny at 2024-01-31T22:21:23+00:00 nir/builder: Fix compilation with gcc-13 when tsan is enabled ../src/compiler/nir/nir_builder.h: In function ‘nir_build_deref_follower’: ../src/compiler/nir/nir_builder.h:1607:1: error: control reaches end of non-void function [-Werror=return-type] 1607 | } Fixes: 4a4e1757381c65653fd6a81cf4e969ddff926ed5 nir: Support deref instructions in lower_var_copies Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27345> (cherry picked from commit 0ab3b3c641fa67f1f538c3b9e21f6a1dcb802081) - - - - - 098fb746 by Mike Blumenkrantz at 2024-01-31T22:21:23+00:00 zink: always map descriptor buffers as COHERENT this is already implied since the buffers must be BAR-allocated, but it ensures the context isn't accessed during unmap Fixes: b06f6e00fba ("zink: fix heap-use-after-free on batch_state with sub-allocated pipe_resources") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27344> (cherry picked from commit c900cca96c4cf6766f5b855e07a0ea4d2584bf22) - - - - - 627a6d79 by Mike Blumenkrantz at 2024-01-31T22:21:23+00:00 zink: fix descriptor buffer unmaps on screen destroy descriptor buffer uses mapped buffers. mapping/unmapping buffers uses a ctx in the function params, but at this time there is no ctx. since the ctx is not actually used for unmapping descriptor buffers, this can instead use a special buffer unmap function to avoid invalid access Fixes: b06f6e00fba ("zink: fix heap-use-after-free on batch_state with sub-allocated pipe_resources") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27344> (cherry picked from commit 0a97d1ebfa24b5016526cf0d79be503810520729) - - - - - 438a064a by Hyunjun Ko at 2024-01-31T22:21:23+00:00 anv/video: fix out-of-bounds read Since STD_VIDEO_H265_CHROMA_QP_OFFSET_TILE_COLS_LIST_SIZE is 19. Fixes: 8d519eb5 ("anv: add initial video decode support for h265") Closes: mesa/mesa#10529 Signed-off-by: Hyunjun Ko <zz...@igalia.com> Acked-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27373> (cherry picked from commit d0d2cf549bad34a6e2f9a40a80784450b51168be) - - - - - a085877c by Iago Toral Quiroga at 2024-01-31T22:21:24+00:00 broadcom/compiler: fix incorrect flags setup in non-uniform if path If the ELSE block is cheap then we don't emit the branch instruction but we still want to generate the flags, since these are setting the flags for the THEN block too. Fixes: e401add741 ("broadcom/compiler: skip jumps in non-uniform if/then when block cost is small") Reviewed-by: Alejandro Piñeiro <apinhe...@igalia.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27211> (cherry picked from commit 29d4924e5e5b2460d442012e05c210c03b0747f7) - - - - - f7c73de1 by Iago Toral Quiroga at 2024-01-31T22:21:24+00:00 broadcom/compiler: fix incorrect flags update for subgroup elect c->execute is 0 (not the block index) for lanes currently active under non-uniform control flow. Also this simplifies a bit the instructions we emit for flag generation, both for uniform and non-uniform control flow. Reviewed-by: Alejandro Piñeiro <apinhe...@igalia.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27211> (cherry picked from commit 7bdc8898b15333223a7fe2ba8470da1349143897) - - - - - a3a927a1 by Iago Toral Quiroga at 2024-01-31T22:21:24+00:00 broadcom/compiler: be more careful with unifa in non-uniform control flow If the lane from which the hardware writes the unifa address is disabled, then we may end up with a bogus address and invalid memory accesses from follow-up ldunifa. Instead of always disabling unifa loads in non-uniform control flow we can try to see if the address is prouced from a nir register (which is the only case where we do conditional writes under non-uniform control flow in ntq_store_def), and only disable it in that case. When enabling subgroups for graphics pipelines, this fixes a GMP violation in the simulator with the following test (which has non-uniform control flow writing unifa with lane 0 disabled, which is the lane from which the unifa takes the address): dEQP-VK.subgroups.ballot_broadcast.graphics.subgroupbroadcastfirst_int Reviewed-by: Alejandro Piñeiro <apinhe...@igalia.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27211> (cherry picked from commit 5b269814fcfcc2a947b8abc0dc4144124e7e59b2) - - - - - 63dc250b by Karol Herbst at 2024-01-31T22:21:24+00:00 clc: force fPIC for every user when using shared LLVM As we want to start using `dladdr`, this is needed to prevent `dladdr` returning information of the wrong file. Fixes tag as it's required by the actual fix. Signed-off-by: Karol Herbst <kher...@redhat.com> Fixes: e22491c8326 ("clc: fetch clang resource dir at runtime") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25568> (cherry picked from commit 8efd11fce99710757b14cb575f33778f730ec904) - - - - - ec84f5a1 by Antoine Coutant at 2024-01-31T22:21:24+00:00 clc: retrieve libclang path at runtime. LLVM_LIB_DIR is a variable used for runtime compilations. When cross compiling, LLVM_LIB_DIR must be set to the libclang path on the target. So, this path should not be retrieved during compilation but at runtime. dladdr uses an address to search for a loaded library. If a library is found, it returns information about it. The path to the libclang library can therefore be retrieved using one of its functions. This is useful because we don't know the name of the libclang library (libclang.so.X or libclang-cpp.so.X) v2 (Karol): use clang::CompilerInvocation::CreateFromArgs for dladdr v3 (Karol): follow symlinks to fix errors on debian Fixes: e22491c8326 ("clc: fetch clang resource dir at runtime") Signed-off-by: Antoine Coutant <antoine.cout...@smile.fr> Reviewed-by: Karol Herbst <kher...@redhat.com> Reviewed-by (v1): Jesse Natalie <jenat...@microsoft.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25568> (cherry picked from commit 445aacb4217cbf5fb7be604c5484eb84c3c06497) - - - - - 74a0eb9c by Daniel Schürmann at 2024-01-31T22:21:24+00:00 aco/insert_exec_mask: Fix unconditional demote at top-level control flow. Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27362> (cherry picked from commit c309d2017230e657fd042b9b9dd7acd1c621d2c5) - - - - - 03ecd8b0 by Eric Engestrom at 2024-01-31T23:29:42+00:00 VERSION: bump for 24.0.0 - - - - - 30 changed files: - .pick_status.json - VERSION - meson.build - src/amd/compiler/aco_insert_exec_mask.cpp - src/amd/compiler/aco_optimizer.cpp - src/amd/vulkan/meta/radv_meta.c - src/amd/vulkan/radv_debug.c - src/amd/vulkan/radv_instance.c - src/amd/vulkan/radv_sampler.c - src/broadcom/compiler/nir_to_vir.c - src/compiler/clc/clc_helpers.cpp - src/compiler/clc/meson.build - src/compiler/nir/nir_builder.h - src/compiler/nir/nir_lower_int64.c - src/compiler/spirv/spirv_to_nir.c - src/freedreno/drm/freedreno_device.c - src/freedreno/ir3/ir3_compiler.c - src/gallium/auxiliary/driver_trace/tr_dump.c - src/gallium/auxiliary/gallivm/lp_bld_nir.c - src/gallium/drivers/panfrost/pan_blit.c - src/gallium/drivers/panfrost/pan_cmdstream.c - src/gallium/drivers/panfrost/pan_context.c - src/gallium/drivers/panfrost/pan_job.c - src/gallium/drivers/panfrost/pan_resource.c - src/gallium/drivers/panfrost/pan_resource.h - src/gallium/drivers/r600/r600_pipe_common.c - src/gallium/drivers/radeonsi/si_compute_blit.c - src/gallium/drivers/radeonsi/si_get.c - src/gallium/drivers/radeonsi/si_pipe.c - src/gallium/drivers/radeonsi/si_state_draw.cpp The diff was not included because it is too large. View it on GitLab: https://salsa.debian.org/xorg-team/lib/mesa/-/compare/808f056688bbfb5be23bb78ae2cc747c91c86fbf...03ecd8b0a517e528d790a3d252194f7b898d0e8f -- View it on GitLab: https://salsa.debian.org/xorg-team/lib/mesa/-/compare/808f056688bbfb5be23bb78ae2cc747c91c86fbf...03ecd8b0a517e528d790a3d252194f7b898d0e8f You're receiving this email because of your account on salsa.debian.org.
