[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694549#comment-13694549 ]
ASF subversion and git services commented on DERBY-673: ------------------------------------------------------- Commit 1497230 from [~dagw] [ https://svn.apache.org/r1497230 ] DERBY-673: Get rid of the NodeFactory Remove an erroneously re-introduced "public" keyword from method getParameterTypes. This removes a FindBugs warning about "exposing internal representation by returning reference to mutable object". > Get rid of the NodeFactory > -------------------------- > > Key: DERBY-673 > URL: https://issues.apache.org/jira/browse/DERBY-673 > Project: Derby > Issue Type: Improvement > Components: SQL > Reporter: Rick Hillegas > Assignee: Dag H. Wanvik > Labels: derby_triage10_11 > Attachments: derby-673-1.diff.gz, derby-673-1.status, > derby-673-2.diff.gz, derby-673-2.status, derby-673-3.diff.gz, > derby-673-3.status, derby-673-fixcomments.diff, > derby-673-typesafe-lists-1.diff, derby-673-typesafe-lists-1.status, > nodefactory-31.status, nodefactory-31.zip > > > This piece of code once had a purpose in life. It was one of the > double-joints which allowed cloudscape to ship with and without compiler > support for the synchronization language. Synchronization has been removed. > If we want to plug in optional language components, I think there are better > ways to do this. > The NodeFactory turned into a big, sprawling piece of code. At some point > this code was slimmed down by telescoping all of its factory methods into a > couple unwieldly, weakly-typed overloads backed by cumbersome logic in the > actual node constructors. I would like to reintroduce strongly typed node > constructors which the parser can call directly. This will make node > generation easier to read and less brittle and it will get rid of the now > useless NodeFactory class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira