[
https://issues.apache.org/jira/browse/DERBY-6904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028473#comment-16028473
]
Harshvardhan Gupta edited comment on DERBY-6904 at 5/29/17 3:55 PM:
--------------------------------------------------------------------
Thanks for reviewing the patch. Your comments are much appreciated.
As you rightly pointed out, cycling feature requires only boolean for storage
and processing. The new changes are attached in 6904_4.diff which uses boolean
data type. Also I have made changes to IdentitySequenceTest by changing them to
reflect the new expected behaviour.
Regarding SYSSEQUNCES, yes it is mostly untouched, a new sequences is created
when we change the cycling behaviour. (which also copies other autoincrement
info such as increment value, current value etc. from existing sequence)
Other than two of the above test cases, we should add new test cases to
completely cover all the functionality introduced with this patch. I am
creating new subtasks for tracking test coverage and documentation.
For test coverage, let us discuss on the following subtask -
https://issues.apache.org/jira/browse/DERBY-6935
was (Author: harshvardhan145):
Thanks for reviewing the patch. Your comments are much appreciated.
As you rightly pointed out, cycling feature requires only boolean for storage
and processing. The new changes are attached in 6904_4.diff which uses boolean
data type. Also I have made changes to IdentitySequenceTest by changing them to
reflect the new expected behaviour.
Other than two of the above test cases, we should add new test cases to
completely cover all the functionality introduced with this patch. I am
creating new subtasks for tracking test coverage and documentation.
For test coverage, let us discuss on the following subtask -
https://issues.apache.org/jira/browse/DERBY-6935
> Enhance ALTER TABLE to allow CYCLE option to be changed.
> --------------------------------------------------------
>
> Key: DERBY-6904
> URL: https://issues.apache.org/jira/browse/DERBY-6904
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 10.13.1.0
> Reporter: Bryan Pendleton
> Assignee: Harshvardhan Gupta
> Priority: Minor
> Attachments: 6904_2.diff, 6904_3.diff, 6904_4.diff, 6904.diff,
> columnMismatch, compareDbName
>
>
> It would be nice to have a variant of the ALTER TABLE statement,
> similar to the SET INCREMENT BY or SET RESTART WITH variants,
> that allowed a user to change the CYCLE option on an IDENTITY column.
> I think that the code flow for this could be closely modelled on the
> code flow for the SET INCREMENT BY variant: after the statement
> is parsed, we simply need to drop and recreate the underlying SEQUENCE
> object with the desired CYCLE option (and preserving all the other
> aspects of the underlying SEQUENCE object.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
