[ http://issues.apache.org/jira/browse/DERBY-1473?page=all ]
Kristian Waagan updated DERBY-1473:
-----------------------------------
Attachment: derby-1473-1b-streaming.diff
derby-1473-2b-streamingtests.diff
Hi Knut Anders,
- Fixed.
- Thanks for catching this. It's a leftover from the previos implementation.
This constructor is no longer allowed to be used for length less streams. I
deleted the else-block.
- I have added comments to the two constructors. I would appreciate guidelines
of how to use IllegalArgumentExceptions, SanityManager.ASSERT or similar. I do
want to signal invalid use of the class, as it can cause much confusion if the
illegal arguments are ignored and execution proceeds as normal.
- I have added braces around the block.
I also made some changes for the patch to work with the move of JUnit
infrastructure classes, and refreshed the patches. I ran the jdbc40 suite for a
sanity check (1 expected error - TestQueryObject), and have a new derbyall
running.
Patches are now at revision b.
> Add cut-off and truncation logic to streaming classes in the embedded driver
> ----------------------------------------------------------------------------
>
> Key: DERBY-1473
> URL: http://issues.apache.org/jira/browse/DERBY-1473
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.2.1.0
> Reporter: Kristian Waagan
> Assigned To: Kristian Waagan
> Fix For: 10.2.1.0
>
> Attachments: derby-1473-1a-streaming.diff,
> derby-1473-1a-streaming.stat, derby-1473-1b-streaming.diff,
> derby-1473-2a-streamingtests.diff, derby-1473-2a-streamingtests.stat,
> derby-1473-2b-streamingtests.diff
>
>
> When streaming data to Derby, the application stream will be wrapped in a
> Derby-specific stream to convert the data to the correct representation. At a
> minimum, this consists of getting the data to the on-disk format used by
> Derby.
> The wrapping stream can be extended to provide the following features at an
> earlier stage:
> a) Data cut-off when the maximum allowed size is exceeded
> b) Truncation of trailing blanks where allowed
> Both features can reduce the amount of data needed to be kept in memory on
> insertion.
> Implementing this will require additional column/data type information in the
> streaming class(es). The implementation must be able to handle streams for
> which the length is specified and also streams with unknown/unspecified
> length.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
