[
http://issues.apache.org/jira/browse/DERBY-606?page=comments#action_12454827 ]
Suresh Thalamati commented on DERBY-606:
----------------------------------------
Thanks for working on this issue. Patch looks good , i have only few minor
comments.
1) Two new classes CompressSpacePageOperation10_2.java and
CompressSpacePageOperation10_3.java may not be required. I think
CompressSpacePageOperation.java
can be modified to handle the new 10.3/10.2 behavior and create one new class
CompressSpacePageOperation10_2 that extends the CompressSpacePageOperation
and sets the old format id.
2) CompressSpacePageOperation10_2.java Copyright has a wrong class name.
Index:
java/engine/org/apache/derby/impl/store/raw/data/CompressSpacePageOperation10_2.java
+ Derby - Class org.apache.derby.impl.store.raw.data.ChainAllocPageOperation
3) Minor comment error in
Index: java/engine/org/apache/derby/iapi/store/raw/RawStoreFactory.java
+ /** Derby Store Minor Version (2) **/
+ public static final int DERBY_STORE_MINOR_VERSION_3 = 3;
version number in the comment , should be 3.
4) Great work with tests. One minor nit :
When I looked first time , following change in the OnlineCompressTest.java,
got me confused.
+ int[] test_cases = {104000};
+ for (int i = 0; i < test_cases.length; i++)
+ {
+ // first create new table and run the tests.
+ createAndLoadLargeTable(conn, true, table_name, test_cases[i], 0);
+
I am sure you must have added it to try different no of rows to reproduce the
problem. Now that you know the no of of rows required to reproduce
the problem. It might be better to change the code to noRows= 104000
instead of test_cases; just to make it more clear.
5) tests/upgradeTests/Upgrade_10_2_10_3.java has to be disabled due to
DERBY-1135 bug , please see build.xml in this directory.
There is another Jira entry
(http://issues.apache.org/jira/browse/DERBY-1689) to add upgrade tests
for 10.2 to 102. If you would like to address the 10.2 to 10.3 upgrade
support in a separate patch, that is fine with me.
> SYSCS_UTIL.SYSCS_INPLACE_COMPRESS_TABLE fails on (very) large tables
> --------------------------------------------------------------------
>
> Key: DERBY-606
> URL: http://issues.apache.org/jira/browse/DERBY-606
> Project: Derby
> Issue Type: Bug
> Components: Store
> Affects Versions: 10.1.1.0
> Environment: Java 1.5.0_04 on Windows Server 2003 Web Edition
> Reporter: Jeffrey Aguilera
> Assigned To: Mayuresh Nirhali
> Fix For: 10.3.0.0
>
> Attachments: A606Test.java, derby606-v2.diff, derby606_v1.diff
>
>
> SYSCS_UTIL.SYSCS_INPLACE_COMPRESS_TABLE fails with one of the following error
> messages when applied to a very large table (>2GB):
> Log operation null encounters error writing itself out to the log stream,
> this could be caused by an errant log operation or internal log buffer full
> due to excessively large log operation. SQLSTATE: XJ001: Java exception: ':
> java.io.IOException'.
> or
> The exception 'java.lang.ArrayIndexOutOfBoundsException' was thrown while
> evaluating an expression. SQLSTATE: XJ001: Java exception: ':
> java.lang.ArrayIndexOutOfBoundsException'.
> In either case, no entry is written to the console log or to derby.log.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
