On Thu, Jan 19, 2023 at 3:29 PM Eric Covener <cove...@gmail.com> wrote: > > On Thu, Jan 19, 2023 at 12:20 PM Eric Covener <cove...@gmail.com> wrote: > > > > 1.7.1-rc1 is here: > > > > https://apr.apache.org/dev/dist/ > > > > For the release of apr-1.7.1 > > [ ] +1 looks great! > > [ ] -1 something is broken > > > > I will let the vote run through mid-week. > > > > I've got no idea what I'm doing here, so I've adopted the -rcX style > > from recent httpd releases as it's likely many version numbers would > > be burned otherwise. > > > > I am working from > > https://svn.apache.org/repos/asf/apr/site/trunk/tools/release.sh > > plus what I can sort out from > > https://svn.apache.org/repos/asf/httpd/dev-tools/release > > Some issues on AIX, 3 tests failing in testshm that worked in 1.7.0 > (no other regressions) > > $ grep -ri USE_SHMEM apr-1.7.*/include/apr.h > apr-1.7.0/include/apr.h:#define APR_USE_SHMEM_MMAP_TMP 0 > apr-1.7.0/include/apr.h:#define APR_USE_SHMEM_MMAP_SHM 0 > apr-1.7.0/include/apr.h:#define APR_USE_SHMEM_MMAP_ZERO 0 > apr-1.7.0/include/apr.h:#define APR_USE_SHMEM_SHMGET_ANON 0 > apr-1.7.0/include/apr.h:#define APR_USE_SHMEM_SHMGET 1 > apr-1.7.0/include/apr.h:#define APR_USE_SHMEM_MMAP_ANON 1 > apr-1.7.0/include/apr.h:#define APR_USE_SHMEM_BEOS 0 > apr-1.7.1-rc1/include/apr.h:#define APR_USE_SHMEM_MMAP_TMP 0 > apr-1.7.1-rc1/include/apr.h:#define APR_USE_SHMEM_MMAP_SHM 1 > apr-1.7.1-rc1/include/apr.h:#define APR_USE_SHMEM_MMAP_ZERO 0 > apr-1.7.1-rc1/include/apr.h:#define APR_USE_SHMEM_SHMGET_ANON 0 > apr-1.7.1-rc1/include/apr.h:#define APR_USE_SHMEM_SHMGET 0 > apr-1.7.1-rc1/include/apr.h:#define APR_USE_SHMEM_MMAP_ANON 1 > apr-1.7.1-rc1/include/apr.h:#define APR_USE_SHMEM_BEOS 0 > > Which is from http://svn.apache.org/viewvc?view=revision&revision=1901038
The failing tests are the name-based tests. >From the AIX manual (lseek via apr_file_trunc) If the FileDescriptor parameter refers to a shared memory object, the lseek subroutine fails with EINVAL. ... EINVAL The resulting offset would be greater than the maximum offset allowed for the file or device associated with FileDescriptor. The lseek subroutine was used with a file descriptor obtained from a call to the shm_open subroutine. #if APR_USE_SHMEM_MMAP_SHM /* FIXME: SysV uses 0600... should we? */ tmpfd = shm_open(shm_name, O_RDWR | O_CREAT | O_EXCL, 0644); if (tmpfd == -1) { return errno; } status = apr_os_file_put(&file, &tmpfd, APR_READ | APR_WRITE | APR_CREATE | APR_EXCL, pool); if (status != APR_SUCCESS) { return status; } status = apr_file_trunc(file, new_m->realsize); if (status != APR_SUCCESS && status != APR_ESPIPE) { shm_unlink(shm_name); /* we're failing, remove the object */ return status; } new_m->base = mmap(NULL, new_m->realsize, PROT_READ | PROT_WRITE, MAP_SHARED, tmpfd, 0); /* FIXME: check for errors */ status = apr_file_close(file); if (status != APR_SUCCESS) { return status; }