paulrutter commented on PR #310: URL: https://github.com/apache/felix-dev/pull/310#issuecomment-2084938020
I kept both examples in the whiteboard bundle, as both have value: * https://github.com/apache/felix-dev/pull/310/files#diff-a493047a289b4bd7db717df5c308a98988f0417824efa8819cf0e415a2dc750e is the one that uses the WS container to register the mapping on. * https://github.com/apache/felix-dev/pull/310/files#diff-53fea368c43e981c1e37100c78de7e8b2087eb9aa51ceedefdddc6138ae88ca2 is the example that extends `JettyWebSocketServlet`, but requires a workaround (see base class). For my own project, the first approach wouldn't work, as we register multiple instances of the same servlet class which would then overwrite the WS mapping on the WebSocket container. Using the `JettyWebSocketServlet` approach, this does not happen, as `JettyWebSocketServlet` is used to upgrade a regular `HttpServletRequest` to a WebSocket request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
