sebastian-nagel commented on a change in pull request #691:
URL: https://github.com/apache/nutch/pull/691#discussion_r659610611
##########
File path: docker/Dockerfile
##########
@@ -20,10 +20,12 @@ WORKDIR /root/
# Install dependencies
RUN apk update
-RUN apk --no-cache add apache-ant bash git openjdk11
+RUN apk --no-cache add apache-ant bash git openjdk11 supervisor
+# Establish environment variables
RUN echo 'export JAVA_HOME=/usr/lib/jvm/java-11-openjdk' >> $HOME/.bashrc
-env NUTCH_HOME='/root/nutch_source/runtime/local'
+ENV JAVA_HOME '/usr/lib/jvm/java-11-openjdk'
Review comment:
The [Dockerfile
reference](https://docs.docker.com/engine/reference/builder/#env) discourages
the use of `ENV var val` in favor of `ENV var=val`. I've seen this variant the
first time and had to try out and read the documentation.
+1 to unify how JAVA_HOME and NUTCH_HOME are set. Also good not to force the
usage of the bash as command-line shell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
