Geoffrey Young wrote:


Steve Hay wrote:

Hi,

Earlier today I reported test failures in filter/in_str_consume, apache/cookie, apache/cookie2 and apr/perlio.

Geoff has kindly come up with a solution for the two cookie test script failures, but I've inadvertently found another way to "fix" them, and also the filter/in_str_consume test: simply install LWP (and it's pre-requisites: HTML-Tagset, HTML-Parser and URI)!


ah. that explains it. I was wondering why the GET was working for me _without_ the leading /, which is always required per the RFC. I guess LWP adds it behind the scenes.

at any rate, Apache::Test has a base implementation that creates GET and other methods when LWP is not found. it also exports have_lwp() so testers can rely on other aspects of LWP in their tests.

Steve, LWP is not required to run most of the tests, since Doug wrote an internal simple replacement for LWP which kicks-in when LWP is not available. it doesn't have all the features that LWP has, but good enough for most of the tests. So when we find a test that fails because LWP is not available we should either make its run optional or see if it's simple enough to fix the Apache::TestRequest client to do the work.


Unrelated we need to test the test suite with LWP not available, I'd even suggest a new command line option -nolwp which will make sure that it's not loaded and the test suite is running without it. That will make it easy to test. Sounds goood?

so, I guess we need to fix all the places where location does not have an initial slash. additionally, we should consider whether to make GET and the other methods prepend an initial / to the uri when LWP is not present.

This is certainly a bug. If you find any others they should be fixed.


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to