Joe Schaefer wrote:
- why upcased SV, P?
Because a lowercase "sv" appears in the macro as
an attribute of acct. Using a lowercase "sv" in the macro argument will confuse the preprocessor.
so will choosing a different variable name work? At least that's the practice we have been using so far. Or do you think it's better to just use upcased equivalents?
I find that confusing.
I agree that we have different values on what is confusing
in source code. I dislike seeing do-nothing macros like STMT_START/STMT_END in C source, but I won't argue the point.
It's not about likes or dislikes, but about consistency. Every time a new committer comes in, they come with their own preferences, but they need to adhere to the style/conventions deployed by the project in order to keep things maintainable. Alternatively you can suggest to change things if the rest agrees with that. If you think that using those macros is not a good style, feel free to adjust the rest of the code, to use the other style. But having a mix of styles doesn't contribute to the maintanability of the project.
[OT: it seems that 'maintainability' is not an proper English word, but google has found 262,000 references to it. Is that how new words emerge into the language? what's the proper word for the 'state of being maintainable'?]
@@ -116,9 +169,6 @@ * mess, trying to destroy an already destroyed pool or even worse * a pool allocate in the place of the old one. */ - apr_pool_cleanup_register(child_pool, (void *)child_pool, - mpxs_apr_pool_cleanup, - apr_pool_cleanup_null);
As you have removed that code, is the comment above still relevant?
Yes, it's still relevant.
should it be moved elsewhere? It seems to be hanging in the air now.
No it isn't hanging in the air. It *could* be moved down past
the #if APR_POOL_DEBUG block so it's closer to the MP_APR_POOL_TAKES_OWNERSHIP call,
+1
and I wonder if that debug block shouldn't be removed entirely, but that's Philippe's call. Not mine.
I wrote that code to debug pools relationship. Please keep it in.
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
